After running rework on a css file the last property in the declarations is missing a semicolon.
border: 1px solid var(var-border-color);
border: 1px solid black;
border: 1px solid black
*notice the semicolon is missing
I don't think the semi-colon needs to be there for minified output. It should be there for un-minified output though.
it'll break a bunch of tests to change now so im kinda meh about it haha, but I would agree that uncompressed might as well leave it on
I hear you. It would just mean updating the uncompressed *.css.out files. You either do it in rework or update the uncompressed files by hand, which is what I've been doing shrug
well if you're using rework already there's no reason to even touch the output files really, that's not invalid CSS
You're right it isn't invalid css, but a lot of people work with strict coding guidelines. Adding a semicolon is more "correct", meaning consistent. Would you accept a pull request if I "fixed" this for uncompressed files?
yeah I'm fine with it we would just have to update the tests in rework/css-stringify/rework-mixins etc
OK. Cool. Will put this together.