Skip to content

Loading…

Add Travis CI #37

Merged
merged 1 commit into from

4 participants

@ai
ai commented

Travis CI is very nice project It will:

  • test Rework in different nodejs versions;
  • show for new users, that tests are pass now;
  • GitHub has integration with Travis CI and will show tests status in pull requests.

You will be need also login on Travis CI (one click via GitHub) and activate rework repo in Profile. You can read Getting started.

Also you can add node 0.6 to tests if you want.

Also, maybe it will be better to call scripts via npm from package.json scripts?

@tj tj merged commit 92a1875 into reworkcss:master
@ai
ai commented

Do you need help with Travis CI and another rework components?

@tj
rework member
tj commented

I've used it quite a bit it's just usually a bit unnecessary for string manipulation based stuff since that's all vanilla js and not much node io etc but it doesn't hurt!

@ForbesLindesay

I mostly just like that you can display a badge that states that unit tests get run on every commit. Plus it makes sure I never forget.

@tj
rework member
tj commented

I dont make commits without running tests but for env-sensitive stuff it's definitely great

@ai
ai commented

Travis is about assurance :).

@vendethiel

And pull requests too ;).

@ForbesLindesay

Yeh, it's about letting other people see that you did it (and what the results were).

@tj
rework member
tj commented

true true, pull-requests is definitely a good point

@ai
ai commented

I also add Travis CI configs to reworkcss/rework-mixins#2 and reworkcss/css-whitespace#9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 5, 2013
  1. @ai

    Add configs for Travis CI

    ai committed
Showing with 7 additions and 1 deletion.
  1. +3 −0 .travis.yml
  2. +4 −1 package.json
View
3 .travis.yml
@@ -0,0 +1,3 @@
+language: node_js
+node_js:
+ - 0.8
View
5 package.json
@@ -17,5 +17,8 @@
"mocha": "*",
"should": "*"
},
- "main": "index"
+ "main": "index",
+ "scripts": {
+ "test": "mocha --require should --reporter spec"
+ }
}
Something went wrong with that request. Please try again.