WiP - CSI Spec 51e48d38 (gRPC Errors) #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akutz
changed the title
akutz
force-pushed
the
feature/csi-spec-51e48d3
branch
2 times, most recently
from
541cbb6
to
b356efe
Compare
|
@akutz gocsi/mock returns error |
|
@akutz also, the following happened when I run the mock and tries to nodepublishvolume a non-existent volume: Edit : I actually don't know what's causing it.. i thought it was above, but no. Re-checking to make sure i m not sending bad data causing mock to crash. Edit @akutz you are assuming volume has attributes, but it doesn't. |
|
Thanks Vlad. I’ll take a look. Pretty sure I know what the problem is. |
|
For your testing, find the Mock SP’s interceptor list and add the option to the spec validator that requires volumes to exist. |
This patch introduces support for the CSI specification, revision 51e48d38. This is a very important update as it shutters the old CSI error model in favor of the new, standard gRPC error codes.
akutz
force-pushed
the
feature/csi-spec-51e48d3
branch
6 times, most recently
from
1a8cfba
to
cf5b8f7
Compare
This patch removes all of the previous CSI helper functions contained in GoCSI. With the new error model the helper functions were largely vestigial. There is one remaining/new function -- PageAllVolumes. This function uses the ListVolumes RPC and paging to return a channel on which all volumes may be received by issuing paged requests to the SP until all volumes have been returned from the server.
akutz
force-pushed
the
feature/csi-spec-51e48d3
branch
from
cf5b8f7
to
a17c5e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces support for the CSI specification, revision 51e48d38. This is a very important update as it shutters the old CSI error model in favor of the new, standard gRPC error codes.
This patch also includes new, unified client/server interceptors for validating requests/responses against the CSI specification, handling logging, and transmitting a unique request ID from the client to the server.
Updatecsc