Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to remove dependency on perl for 'list' feature #439

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@mux23
Copy link
Contributor

commented May 25, 2016

The install relies on perl for a single-line rexex when scraping the
Bintray website for a list of REX-Ray versions available for install.

This tiny update removes the need for the installing operating system to
have Perl installed, mostly because RHEL does not have Perl installed by
default. One other option would have been to trap the error and echo
some sort of message calling for the user to install Perl, but that
seems drastic, considering the same page scrape can be executed just
fine using the bash built-in command 'cut'.

This update should not affect any other versions, as 'cut' hasn't really
changed its syntax in decades.

update to remove dependency on perl for 'list' feature
The install relies on perl for a single-line rexex when scraping the
Bintray website for a list of REX-Ray versions available for install.

This tiny update removes the need for the installing operating system to
have Perl installed, mostly because RHEL does not have Perl installed by
default. One other option would have been to trap the error and echo
some sort of message calling for the user to install Perl, but that
seems drastic, considering the same page scrape can be executed just
fine using the bash built-in command 'cut'.

This update should not affect any other versions, as 'cut' hasn't really
changed its syntax in decades.
@coveralls

This comment has been minimized.

Copy link

commented May 25, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling ff2571e on installer-remove-perl into d668199 on master.

@codecov-io

This comment has been minimized.

Copy link

commented May 25, 2016

Current coverage is 100%

Merging #439 into master will not change coverage

@@           master   #439   diff @@
====================================
  Files           1      1          
  Lines          93     93          
  Methods         0      0          
  Messages        0      0          
  Branches        0      0          
====================================
  Hits           93     93          
  Misses          0      0          
  Partials        0      0          

Sunburst

Powered by Codecov. Last updated by 2d34e25...ff2571e

@akutz akutz force-pushed the master branch from 53cd051 to e1161c5 May 26, 2016

@akutz

This comment has been minimized.

Copy link
Member

commented May 26, 2016

Hi @mux23,

Seriously? RHEL doesn't have Perl by default? This was tested on CentOS, which is based on RHEL. Thanks for doing this BTW. I just don't know the current script was ever validated if the above failed.

@akutz akutz force-pushed the master branch 2 times, most recently from 33b4a86 to 2d34e25 May 27, 2016

@clintkitson clintkitson added this to the 0.4.0 milestone Jun 10, 2016

@akutz akutz modified the milestones: 0.4.1, 0.4.0 Jun 21, 2016

@akutz

This comment has been minimized.

Copy link
Member

commented Jun 28, 2016

Hi @mux23,

This is being closed as your commit will be merged as part of #474.

@akutz akutz closed this Jun 28, 2016

@akutz akutz deleted the installer-remove-perl branch Jun 28, 2016

akutz added a commit to akutz/rexray that referenced this pull request Jul 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.