forked from nlohmann/json
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update #1
Merged
rfattic-extensis
merged 152 commits into
rfattic-extensis:develop
from
nlohmann:develop
Jan 12, 2017
Merged
update #1
rfattic-extensis
merged 152 commits into
rfattic-extensis:develop
from
nlohmann:develop
Jan 12, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/clang sanitize
Add Doozer build badge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files to change
There are currently two files which need to be edited:
src/json.hpp.re2c
(note the.re2c
suffix) - This file contains a comment section which describes the JSON lexic. This section is translated byre2c
into filesrc/json.hpp
which is plain "vanilla" C++11 code. (In fact, the generated lexer consists of some hundred lines ofgoto
s, which is a hint you never want to edit this file...).If you only edit file
src/json.hpp
(without the.re2c
suffix), your changes will be overwritten as soon as the lexer is touched again. To generate thesrc/json.hpp
file which is actually used during compilation of the tests and all other code, please executeTo run
re2c
and generate/overwrite filesrc/json.hpp
with your changes in filesrc/json.hpp.re2c
.test/src/unit.cpp
- This contains the Catch unit tests which currently cover 100 % of the library's code.If you add or change a feature, please also add a unit test to this file. The unit tests can be compiled with
and can be executed with
The test cases are also executed with several different compilers on Travis once you open a pull request.
Please understand that I cannot accept pull requests changing only file
src/json.hpp
.Note
Please don't
src/json.hpp
-- please read the paragraph above and understand whysrc/json.hpp.re2c
exists.#ifdef
s or other means.