Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick hack to get GfxTablet working with Gimp 2.8 on kernel 4.17 #95

Merged
merged 1 commit into from Nov 19, 2018

Conversation

@tonyg
Copy link
Collaborator

@tonyg tonyg commented Aug 16, 2018

This switches from the old uinput_user_dev method to the new ioctl-based UI_ABS_SETUP/UI_DEV_SETUP method that X's libinput seems to need these days. After these changes, the device worked in X windows and thus gimp and inkscape; without these changes, Xorg.0.log complained about missing resolution information.

@stellarpower
Copy link

@stellarpower stellarpower commented Aug 26, 2018

Works for me.

@54D-R0807
Copy link

@54D-R0807 54D-R0807 commented Sep 6, 2018

Works for me too, running: openSUSE Leap 15.0; 4.12.14-lp150.12.16-default #1 SMP Tue Aug 14 17:51:27 UTC 2018 (28574e6) x86_64 x86_64 x86_64 GNU/Linux

@atondwal
Copy link

@atondwal atondwal commented Sep 10, 2018

Works for me on Ubuntu LTS 18; Thanks!

@Nikomaru
Copy link

@Nikomaru Nikomaru commented Sep 16, 2018

With system update, and uninstall and reinstall, works in GIMP and on the whole desktop for current Arch. Thank you for that!

@Zanark
Copy link

@Zanark Zanark commented Sep 30, 2018

I got the following errors after compiling the committed changes

networktablet.c: In function ‘init_device’:
networktablet.c:54:35: error: storage size of ‘abs_setup’ isn’t known
           struct uinput_abs_setup abs_setup;
                                   ^
networktablet.c:55:31: error: storage size of ‘setup’ isn’t known
           struct uinput_setup setup;
                               ^
networktablet.c:65:25: error: ‘UI_ABS_SETUP’ undeclared (first use in this function)
           if (ioctl(fd, UI_ABS_SETUP, &abs_setup) < 0)
                         ^
networktablet.c:65:25: note: each undeclared identifier is reported only once for each function it appears in
networktablet.c:97:25: error: ‘UI_DEV_SETUP’ undeclared (first use in this function)
           if (ioctl(fd, UI_DEV_SETUP, &setup) < 0)
                         ^
<builtin>: recipe for target 'networktablet' failed
make: *** [networktablet] Error 1

@tonyg
Copy link
Collaborator Author

@tonyg tonyg commented Sep 30, 2018

@Zanark, could you be building on an older kernel that lacks the uinput_abs_setup definitions in linux/uinput.h?

@Zanark
Copy link

@Zanark Zanark commented Sep 30, 2018

@tonyg I am using Linux Mint 4.15.0-34-generic #37~16.04.1-Ubuntu SMP Tue Aug 28 10:44:06 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

@tonyg
Copy link
Collaborator Author

@tonyg tonyg commented Sep 30, 2018

@Zanark ok, so this is weird. Mint 18.3's linux 4.10.0-38 headers include a uinput.h that doesn't have the version 0.5 patches from August 2015! The mainline 4.10 kernel does have the 0.5 patches.

Check your /usr/include/linux/uinput.h file - if it doesn't have the following, you will have to upgrade Mint somehow to have a linux kernel and headers package that does:

 * Changes/Revisions:
 *	0.5	08/13/2015 (David Herrmann <dh.herrmann@gmail.com> &
 *			    Benjamin Tissoires <benjamin.tissoires@redhat.com>)
 *		- add UI_DEV_SETUP ioctl
 *		- add UI_ABS_SETUP ioctl
 *		- add UI_GET_VERSION ioctl

(I see you're now on 4.15.0-34 -- and if you're suffering the same problem there, the cause is likely the same.)

@tonyg
Copy link
Collaborator Author

@tonyg tonyg commented Sep 30, 2018

@Zanark, Linux Mint 19 "Tara" ships with 4.15.0-20-generic headers that include the 0.5 uinput.h changes, and I have just compiled networktablet using a live install ISO of that system.

@Zanark
Copy link

@Zanark Zanark commented Oct 22, 2018

@tonyg This works like a charm now. I've installed Tara 4.15.0-38-generic and it works perfectly. However when I start the application, my touchpad gets disabled and I'm unable to activate it even after closing the application. Can you please help me out with this.

@tonyg
Copy link
Collaborator Author

@tonyg tonyg commented Oct 22, 2018

Hi @Zanark - I'm glad you got it working to the extent you did, but I'm afraid I have no idea how to help you debug your touchpad issue. Sorry.

@Zanark
Copy link

@Zanark Zanark commented Oct 22, 2018

Okay, I'll try to find a solution and post it here for someone who might face this issue in the future.
Thanx a ton for your help @tonyg 😄

@blackcrack
Copy link

@blackcrack blackcrack commented Oct 24, 2018

Hi Peoples,
@tonyg @stellarpower @54D-R0807 @atondwal @Nikomaru @jt1399 @Devp00l @cbdevnet @loopyd
@joschuck @KevinLi @wech71

i have wrote a mail to rfc2822 on his domain at bitfire.at
and he told, he have absolute no time and he would over give
the GfxTablet to an person who want it maintain and further developing
and where want overtake this project.

Wech71 have wrote Windows-Drivers,
may would it good if he ?
But you as the programmer should talk about it.

you are both be very interested on this like i see and
you like it to programming, so why not post this info in this tread ..

please contact him at his domain over bitfire.at , info@

best regards
Blacky

@wech71
Copy link

@wech71 wech71 commented Oct 24, 2018

Sorry,

same here as rfc2822. I just don't have any time to spare on the project anymore. Also I have near no knowlege about linux/unix development.

@Vrak
Copy link

@Vrak Vrak commented Oct 26, 2018

Working with Kubuntu 18.04

@loopyd
Copy link

@loopyd loopyd commented Oct 26, 2018

@tonyg
Copy link
Collaborator Author

@tonyg tonyg commented Nov 2, 2018

i have wrote a mail to rfc2822 on his domain at bitfire.at
and he told, he have absolute no time and he would over give
the GfxTablet to an person who want it maintain and further developing
and where want overtake this project.

I can't take on full maintainership, but I am definitely able to do things like e.g. merge in this pull request to mainline. @rfc2822, if you'd like to grant me the commit bit I'd be happy to do such small housekeeping tasks as and when I have time.

@rfc2822
Copy link
Owner

@rfc2822 rfc2822 commented Nov 2, 2018

@tonyg Have sent you a collaboration invite

@Capri-Sonne
Copy link

@Capri-Sonne Capri-Sonne commented Nov 17, 2018

Thanks a lot.. solved my issue...Have a great day

@tonyg tonyg closed this Nov 19, 2018
@tonyg tonyg reopened this Nov 19, 2018
@tonyg tonyg merged commit 8c2421b into rfc2822:master Nov 19, 2018
@tonyg
Copy link
Collaborator Author

@tonyg tonyg commented Nov 19, 2018

OK - these changes are on master now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet