New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merging with ffmpeg results in --output not fully controlling output filename #14864

Closed
joeyh opened this Issue Nov 27, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@joeyh

joeyh commented Nov 27, 2017

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.11.26. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

  • I've verified and I assure that I'm running youtube-dl 2017.11.26

Before submitting an issue make sure you have:

  • At least skimmed through the README, most notably the FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other

Description of your issue, suggested solution and other information

When downloading youtube videos with a format that involves merging (including the default bestvideo+bestaudio), and when ffmpeg is used for the merge, --output does not fully control the filename that the merged video is written to. A ".mkv" extension is added to whatever filename --output would generate.

For example, -o out.vid results in:

WARNING: Requested formats are incompatible for merge and will be merged into mkv.
[ffmpeg] Merging formats into "out.vid.mkv"

--get-filename also does not print out the actual filename used in this case.

I was going to use --output to make youtube-dl output to a specific filename in a script; this behavior makes that not practical to do unless I also force the output format to -f best or something like that.

(I have not checked if using avconv for merging also has this behavior.)

@yan12125

This comment has been minimized.

Show comment
Hide comment
@yan12125

yan12125 Nov 28, 2017

Collaborator

This is a known issue #5710. Sadly currently there's no good solution.

Edit: Should be a duplicate of #7137, not #5710

Collaborator

yan12125 commented Nov 28, 2017

This is a known issue #5710. Sadly currently there's no good solution.

Edit: Should be a duplicate of #7137, not #5710

@yan12125 yan12125 closed this Nov 28, 2017

@joeyh

This comment has been minimized.

Show comment
Hide comment
@joeyh

joeyh Nov 28, 2017

I can see the difficulty in making --get-filename work in this situation, but my bug report is primarily about --output not working. It seems to me that for --output, youtube-dl could simply rename the file ffmpeg generates to the filename the user requested.

So, it may be useful to reopen and treat #14864 and #7137 as two separate, though related bugs.

joeyh commented Nov 28, 2017

I can see the difficulty in making --get-filename work in this situation, but my bug report is primarily about --output not working. It seems to me that for --output, youtube-dl could simply rename the file ffmpeg generates to the filename the user requested.

So, it may be useful to reopen and treat #14864 and #7137 as two separate, though related bugs.

@yan12125

This comment has been minimized.

Show comment
Hide comment
@yan12125

yan12125 Nov 28, 2017

Collaborator

It seems to me that for --output, youtube-dl could simply rename the file ffmpeg generates to the filename the user requested.

It's not how --output actually works. Indeed its description can be better.

If --get-filename is fixed, your problem is solved, so I point the related issue.

Collaborator

yan12125 commented Nov 28, 2017

It seems to me that for --output, youtube-dl could simply rename the file ffmpeg generates to the filename the user requested.

It's not how --output actually works. Indeed its description can be better.

If --get-filename is fixed, your problem is solved, so I point the related issue.

@gabrielgrant

This comment has been minimized.

Show comment
Hide comment
@gabrielgrant

gabrielgrant Dec 19, 2017

I'm not sure I follow... it seems like that (making sure the final output is has the file specified filename) is how --output should work, even if it doesn't today. In what circumstances would a user would not want the output contained in the location they've specified?

gabrielgrant commented Dec 19, 2017

I'm not sure I follow... it seems like that (making sure the final output is has the file specified filename) is how --output should work, even if it doesn't today. In what circumstances would a user would not want the output contained in the location they've specified?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment