fix warning (channel id) #21003
fix warning (channel id) #21003
Conversation
|
Can confirm, this fixes the issue with channel ID. |
|
On Vevo videos like MfQoejFPgc0 and 4ohvXEkMiOk, |
|
OK. Also experienced this. Nice that there now is a fix. Experienced with: youtube-dl --verbose --write-sub --sub-lang en,sv --format 18 "http://www.youtube.com/watch?v=kq1PbgeBoQ4" Is from 2008 and has 2,806,445 views. This is not a serious issue as the film does download OK, but gives the message WARNING: unable to extract channel id; please report this issue on https://yt-dl.org/bug |
YouTube recently removed "channelID" meta tag for video page from personal channels (hence the previous commit). This doesn't seem a big concern as you can get the ID from username's hyperlink just fine. However, today I learned that VEVO channels still have it - and it is different form the ID you can get from username's hyperlink: actually, username for VEVO videos now points to a dummy artist channel page (that doesn't show uploads). This change will make it to check channelID meta tag first. so it can correctly link to and get actual uploaded video number from the actual VEVO channel, instead of the dummy artist page. If none found (like the case for personal channel), it falls back to hyperlink on uploader's name. See comments in ytdl-org/youtube-dl#21003
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Fixed to get channel_id from video_details.
This fixes #20982