New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[acast] Fix broken audio URL and timestamp extraction #11521
Conversation
Before first bling was used now we look for the first bling with type BlingAudio. Before publishingDate was a ms unix timestamp now it is iso8601.
@@ -22,7 +23,8 @@ class ACastIE(InfoExtractor): | |||
'id': '57de3baa-4bb0-487e-9418-2692c1277a34', | |||
'ext': 'mp3', | |||
'title': '"Where Are You?": Taipei 101, Taiwan', | |||
'timestamp': 1196172000000, | |||
'timestamp': 1196172000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about this. README says timestamp should be "UNIX timestamp of the moment the video became available" but not if it should be seconds of milliseconds etc
@@ -22,7 +23,8 @@ class ACastIE(InfoExtractor): | |||
'id': '57de3baa-4bb0-487e-9418-2692c1277a34', | |||
'ext': 'mp3', | |||
'title': '"Where Are You?": Taipei 101, Taiwan', | |||
'timestamp': 1196172000000, | |||
'timestamp': 1196172000, | |||
'upload_date': '20071127', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about this. This is because of https://github.com/rg3/youtube-dl/blob/master/youtube_dl/YoutubeDL.py#L1287
for the timestamp, i added it wrong in the wrong way. it should be in seconds(now with your change it's correct).
if you have a url that have multiple |
@remitamine thanks for review! i've added a test with multiple blings nows |
Would you like to be listed in AUTHORS? If so under what name? |
Thanks. Sure, Mattias Wadman |
Done. |
Before first bling was used now we look for the first bling with
type BlingAudio
Before publishingDate was a ms unix timestamp now it is iso8601.
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Fix broken audio URL and timestamp extraction for acast.