[acast] Fix broken audio URL and timestamp extraction #11521

Closed
wants to merge 2 commits into
from

Projects

None yet

2 participants

@wader
Contributor
wader commented Dec 23, 2016

Before first bling was used now we look for the first bling with
type BlingAudio

Before publishingDate was a ms unix timestamp now it is iso8601.

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Fix broken audio URL and timestamp extraction for acast.

@wader wader [acast] Fix broken audio URL and timestamp extraction
Before first bling was used now we look for the first bling with
type BlingAudio.

Before publishingDate was a ms unix timestamp now it is iso8601.
ec6e31e
@wader
Contributor
wader commented Dec 23, 2016
@@ -22,7 +23,8 @@ class ACastIE(InfoExtractor):
'id': '57de3baa-4bb0-487e-9418-2692c1277a34',
'ext': 'mp3',
'title': '"Where Are You?": Taipei 101, Taiwan',
- 'timestamp': 1196172000000,
+ 'timestamp': 1196172000,
@wader
wader Dec 23, 2016 Contributor

Not sure about this. README says timestamp should be "UNIX timestamp of the moment the video became available" but not if it should be seconds of milliseconds etc

@@ -22,7 +23,8 @@ class ACastIE(InfoExtractor):
'id': '57de3baa-4bb0-487e-9418-2692c1277a34',
'ext': 'mp3',
'title': '"Where Are You?": Taipei 101, Taiwan',
- 'timestamp': 1196172000000,
+ 'timestamp': 1196172000,
+ 'upload_date': '20071127',
@remitamine
Collaborator

for the timestamp, i added it wrong in the wrong way. it should be in seconds(now with your change it's correct).

Before first bling was used now we look for the first bling with type BlingAudio.

if you have a url that have multiple blings than add a test.

@wader wader [acast] Add test with multiple blings
6b15d9a
@wader
Contributor
wader commented Dec 24, 2016

@remitamine thanks for review! i've added a test with multiple blings nows

@remitamine
Collaborator

Would you like to be listed in AUTHORS? If so under what name?

@remitamine remitamine closed this Dec 24, 2016
@wader
Contributor
wader commented Dec 24, 2016

Thanks. Sure, Mattias Wadman

@remitamine remitamine added a commit that referenced this pull request Dec 24, 2016
@remitamine remitamine Credit @wader for #11521 d1cd7e0
@remitamine
Collaborator

Done.

@calbrecht calbrecht added a commit to calbrecht/youtube-dl that referenced this pull request Dec 26, 2016
@remitamine @calbrecht remitamine + calbrecht Credit @wader for #11521 b009660
@myg133 myg133 added a commit to myg133/youtube-dl that referenced this pull request Jan 18, 2017
@remitamine @myg133 remitamine + myg133 Credit @wader for #11521 05fdb0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment