Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[acast] Fix broken audio URL and timestamp extraction #11521

Closed
wants to merge 2 commits into from

Conversation

wader
Copy link
Contributor

@wader wader commented Dec 23, 2016

Before first bling was used now we look for the first bling with
type BlingAudio

Before publishingDate was a ms unix timestamp now it is iso8601.

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Fix broken audio URL and timestamp extraction for acast.

Before first bling was used now we look for the first bling with
type BlingAudio.

Before publishingDate was a ms unix timestamp now it is iso8601.
@wader
Copy link
Contributor Author

wader commented Dec 23, 2016

@remitamine

@@ -22,7 +23,8 @@ class ACastIE(InfoExtractor):
'id': '57de3baa-4bb0-487e-9418-2692c1277a34',
'ext': 'mp3',
'title': '"Where Are You?": Taipei 101, Taiwan',
'timestamp': 1196172000000,
'timestamp': 1196172000,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this. README says timestamp should be "UNIX timestamp of the moment the video became available" but not if it should be seconds of milliseconds etc

@@ -22,7 +23,8 @@ class ACastIE(InfoExtractor):
'id': '57de3baa-4bb0-487e-9418-2692c1277a34',
'ext': 'mp3',
'title': '"Where Are You?": Taipei 101, Taiwan',
'timestamp': 1196172000000,
'timestamp': 1196172000,
'upload_date': '20071127',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@remitamine
Copy link
Collaborator

for the timestamp, i added it wrong in the wrong way. it should be in seconds(now with your change it's correct).

Before first bling was used now we look for the first bling with type BlingAudio.

if you have a url that have multiple blings than add a test.

@wader
Copy link
Contributor Author

wader commented Dec 24, 2016

@remitamine thanks for review! i've added a test with multiple blings nows

@remitamine
Copy link
Collaborator

Would you like to be listed in AUTHORS? If so under what name?

@remitamine remitamine closed this Dec 24, 2016
@wader
Copy link
Contributor Author

wader commented Dec 24, 2016

Thanks. Sure, Mattias Wadman

remitamine added a commit that referenced this pull request Dec 24, 2016
@remitamine
Copy link
Collaborator

Done.

calbrecht referenced this pull request in calbrecht/youtube-dl Dec 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants