Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go90 #11975

Closed
wants to merge 8 commits into from
Closed

Go90 #11975

wants to merge 8 commits into from

Conversation

triple-j
Copy link
Contributor

@triple-j triple-j commented Feb 4, 2017

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

This pull request adds support for Go90.com which addresses issue #10127. It uses the existing UplynkPreplayIE extractor in uplynk.py.

@dstftw
Copy link
Collaborator

dstftw commented Feb 5, 2017

  1. Check code with flake8.
  2. Remove all debug output.
  3. Squash commits.
  4. All metadata can be extracted from JSON in page.
  5. Crashes on geo restriction:
> py -2.7 .\youtube_dl\__main__.py https://www.go90.com/profiles/va_07d47f43a7b04eb5b693252f2bd1086b --proxy 127.0.0.1:8118 --write-pages
[Go90] 07d47f43a7b04eb5b693252f2bd1086b: Downloading webpage
[Go90] Saving request to 07d47f43a7b04eb5b693252f2bd1086b_https_-_www.go90.com_profiles_va_07d47f43a7b04eb5b693252f2bd1086b.dump
[Go90] Scrape data from webpage
Traceback (most recent call last):
  File ".\youtube_dl\__main__.py", line 19, in <module>
    youtube_dl.main()
  File "C:\Dev\youtube-dl\master\youtube_dl\__init__.py", line 452, in main
    _real_main(argv)
  File "C:\Dev\youtube-dl\master\youtube_dl\__init__.py", line 442, in _real_main
    retcode = ydl.download(all_urls)
  File "C:\Dev\youtube-dl\master\youtube_dl\YoutubeDL.py", line 1796, in download
    url, force_generic_extractor=self.params.get('force_generic_extractor', False))
  File "C:\Dev\youtube-dl\master\youtube_dl\YoutubeDL.py", line 696, in extract_info
    ie_result = ie.extract(url)
  File "C:\Dev\youtube-dl\master\youtube_dl\extractor\common.py", line 369, in extract
    return self._real_extract(url)
  File "C:\Dev\youtube-dl\master\youtube_dl\extractor\go90.py", line 44, in _real_extract
    self.to_screen("Series Title: " + series_title)
TypeError: coercing to Unicode: need string or buffer, NoneType found

@triple-j
Copy link
Contributor Author

These changes are now obsolete. Go90 changed how they serve video content. And support for Go90 was added in commit b2fff30 by @remitamine.

@triple-j triple-j closed this Apr 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants