Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Travis test also rtmpdump videos #1601

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Collaborator

FiloSottile commented Oct 14, 2013

Is there a reason we are not doing this? Maybe we needed #1565

If this works, I'll convert all the skip_download tests

Collaborator

FiloSottile commented Oct 14, 2013

Ok it works but we need to check if it stable and to quiet that stuff down.

Collaborator

FiloSottile commented Oct 15, 2013

Umh, a strange line to hang on...

Collaborator

jaimeMF commented Nov 24, 2013

I think this change is not the cause of the hang, it happens other times. If the checksum are always the same (I have yet to understand why it always download the same piece of data), I'm +1. The only problem is all the noise it produces (maybe #1680 solve this).

Collaborator

FiloSottile commented Nov 25, 2013

Rebased to re-run, let's see...

Collaborator

FiloSottile commented Nov 25, 2013

Test worked, Cinemassacre md5 changed, Videopremium stayed.

Collaborator

jaimeMF commented Nov 25, 2013

rzhxeo did some improvements on the Cinemassacre extractor, I think he changed some of the rtmp urls, so it's normal. It seems we don't get all the rtmpdump messages now, that's great :)

Collaborator

FiloSottile commented Nov 26, 2013

Great, I know what I'm doing this night then! ;)

On Monday, November 25, 2013, Jaime Marquínez Ferrándiz wrote:

rzhxeo did some improvements on the Cinemassacre extractor, I think he
changed some of the rtmp urls, so it's normal. It seems we don't get all
the rtmpdump messages now, that's great :)


Reply to this email directly or view it on GitHubhttps://github.com/rg3/youtube-dl/pull/1601#issuecomment-29252043
.

Filippo Valsorda

@phihag phihag closed this in e1ccc04 Jan 25, 2015

Collaborator

phihag commented Jan 25, 2015

Thanks! Applied to current youtube-dl master.

@yan12125 yan12125 referenced this pull request Nov 8, 2016

Closed

youtube-dl shows me as a owner , pull request bug maybe #11092

1 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment