Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

temporary fix for the time jumps #2216

Closed
wants to merge 1 commit into from

2 participants

@amq

I have added -t 72000 (20 hours) to force ffmpeg to mux the file when a "time jump" happens.

For some reason every jump I've seen so far (at least 6 in total) was to 20 hours or more.

I think It's a safe value, which won't cause any troubles. There is no chance recording a live stream for 20 hours without interruptions anyway (my personal record is 3 hours).

#2213

@amq amq temporary fix for the time jumps
I have added -t 72000 (20 hours) to force ffmpeg to mux the file when a "time jump" happens.

For some reason every job I've seen so far (at least 6 in total) was to 20 hours or more.

I think It's a safe value, which won't cause any troubles. There is no chance recording a live stream for 20 hours without interruptions anyway (my record is 3 hours).

rg3#2213
7ea2e44
@phihag
Collaborator

This would break HLS videos of over 20 hours or more. I do not see any reason for this limit. If you are sure this occurs with a certain service, please propose a new field where the deficiency is documented, upon which the fix may be applied.

@phihag phihag closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 23, 2014
  1. @amq

    temporary fix for the time jumps

    amq authored
    I have added -t 72000 (20 hours) to force ffmpeg to mux the file when a "time jump" happens.
    
    For some reason every job I've seen so far (at least 6 in total) was to 20 hours or more.
    
    I think It's a safe value, which won't cause any troubles. There is no chance recording a live stream for 20 hours without interruptions anyway (my record is 3 hours).
    
    rg3#2213
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  youtube_dl/downloader/hls.py
View
2  youtube_dl/downloader/hls.py
@@ -13,7 +13,7 @@ def real_download(self, filename, info_dict):
self.report_destination(filename)
tmpfilename = self.temp_name(filename)
- args = ['-y', '-i', url, '-f', 'mp4', '-c', 'copy',
+ args = ['-y', '-i', url, '-t', '72000', '-f', 'mp4', '-c', 'copy',
'-bsf:a', 'aac_adtstoasc', tmpfilename]
for program in ['avconv', 'ffmpeg']:
Something went wrong with that request. Please try again.