YoutubeDL: Make the decision about removing the original file after each... #2442

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@jaimeMF
Collaborator

jaimeMF commented Feb 23, 2014

... postprocessor is run (fixes #2261)

If one of the processors said the file should be kept, it wouldn't pay
attention to the response from the following processors. This was wrong if the
'keep_video' option was False, if the first extractor modifies the original file
and then we extract its audio we don't want to keep the original video file.

I think that's how we should handle the keep_video option, but I want that someone else reviews this change.

YoutubeDL: Make the decision about removing the original file after e…
…ach postprocessor is run (fixes #2261)

If one of the processors said the file should be kept, it wouldn't pay
attention to the response from the following processors. This was wrong if the
'keep_video' option was False, if the first extractor modifies the original file
and then we extract its audio we don't want to keep the original video file.
@JMSwag

This comment has been minimized.

Show comment Hide comment
@JMSwag

JMSwag Feb 23, 2014

LGTM

JMSwag commented Feb 23, 2014

LGTM

@phihag

This comment has been minimized.

Show comment Hide comment
@phihag

phihag Jan 10, 2015

Collaborator

LGTM, feel free to merge. @jaimeMF, can you also have a look at the somewhat related #3829?

Collaborator

phihag commented Jan 10, 2015

LGTM, feel free to merge. @jaimeMF, can you also have a look at the somewhat related #3829?

@jaimeMF

This comment has been minimized.

Show comment Hide comment
@jaimeMF

jaimeMF Jan 11, 2015

Collaborator

Merged in f3ff1a3

Collaborator

jaimeMF commented Jan 11, 2015

Merged in f3ff1a3

@jaimeMF jaimeMF closed this Jan 11, 2015

@jaimeMF jaimeMF deleted the jaimeMF:pp-keep_video-rework branch Jan 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment