Change GenericIE to download all videos on a page #294

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

trammel commented Feb 26, 2012

The GenericIE pattern match is used to download just the first video on a page.

This patch adds an iterator around the current regexes to download all matching video urls.

This could just be re.finditer(r..., webpage), couldn't it?

This looks yucky. Can we reengineer the above code so that mobj.group(1) is always set?

Collaborator

phihag commented Nov 27, 2012

This change would not find HTML5 videos anymore, and the code can be improved as commented. Closing for now, but feel free to file another pull request with the quirks ironed out. Thanks!

phihag closed this Nov 27, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment