Skip to content

Initial implementation of SOCKS4/SOCKS5 support #305

Closed
wants to merge 3 commits into from

3 participants

@thmttch
thmttch commented Mar 8, 2012

Hey,

I hacked together support for SOCKS proxies using some code I found (https://gist.github.com/869791). It works for me, but I haven't tested it any more than that (yet).

How do you feel about putting this back into master? There's a few problems right now, mainly that the socks code is in separate files (and they're not tiny, ~400 lines), so it breaks the nice, clean "download this script and run it" experience.

Let me know what you think. Cheers!

Matt

@rg3
Owner
rg3 commented Mar 8, 2012

youtube-dl is released to the public domain. This module would introduce a dependency on MIT-licensed sources.

@thmttch
thmttch commented Mar 13, 2012

Got it, fair enough. I'll close this pull request then.

@thmttch thmttch closed this Mar 13, 2012
@FiloSottile FiloSottile referenced this pull request Aug 19, 2012
Open

SOCKS proxy support #402

@bluec0re

I've written an public domain socks wrapper for python:
https://gist.github.com/bluec0re/cafd3764412967417fd3

@yan12125 yan12125 referenced this pull request Apr 23, 2016
Open

SOCKS proxy support #9287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.