Use an User-Agent that will allow downloading from fixes #325 #356

merged 1 commit into from Aug 1, 2012


None yet
4 participants

jcarlosgarciasegovia commented Jun 6, 2012

No description provided.


rg3 commented Jun 6, 2012

This should be specific for the InfoExtractor, IMHO.


jcarlosgarciasegovia commented Jun 7, 2012

@rg3 Why?


rg3 commented Jun 7, 2012

Because if you change the user agent you have to re-test everything still works (some sites may serve you different content that breaks the site InfoExtractor), and you are specifically introducing it to be able to download from one site which is known not to work with the default user agent, so it's natural that you'd want to do that specific fix only in the specific situation.

Furthermore, having a common user agent like the one from Firefox allows you to easily test and debug situations with your common browser without having to install a user agent modifier extension, etc.

FiloSottile added a commit to FiloSottile/youtube-dl that referenced this pull request Aug 1, 2012

@FiloSottile FiloSottile referenced this pull request Aug 1, 2012

Merged #386

@phihag phihag merged commit 3c4fc58 into rg3:master Aug 1, 2012


rbrito commented on youtube_dl/ in 3c4fc58 Aug 5, 2012

@phihag, @FiloSottile

For activist reasons, we should not pretend to always be iTunes.

For technical reasons, we should allow information extractors to override the default user-agent from the std_headers dictionary, as it is not impossible to have one site (like serve the content for user-agent A, with another site serving content for user-agent B, with A != B, of course. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment