Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Make encoding process show it's status #454

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
4 participants
Contributor

danut007ro commented Oct 4, 2012

This pull request is capturing avconv output (at least, don't know about ffmpeg) and is showing how much of the encoding it has done, as percentage.

Also, on my system, the aac codec is marked as experimental, so I used libfaac for aac encoding (if there is another option, that code can be removed)

Collaborator

FiloSottile commented Oct 4, 2012

Will check how it plays with ffmpeg while I work on ffmpeg/avconv recognition and then I will merge. Thanks!

Contributor

danut007ro commented Oct 4, 2012

Great!

I don't know how the output from ffmpeg looks like (it should essentially be the same) but by changing the pattern based on encoder should do it. Oh and also please check the output of ffprobe.

Thanks

Collaborator

phihag commented Oct 5, 2012

Certainly looks good, needs to be tested with non-interactive output. I'm indifferent about libfaac vs aac, as long as it works by default on most systems. Will try it this weekend, but feel free to merge, @FiloSottile .

Collaborator

FiloSottile commented Oct 9, 2012

Could you rebase your work so that it is a single commit, without merges and unrelated commits? (I can do it for you if it is ok, but it is not kind rebasing other people's work without permission)

Contributor

danut007ro commented Oct 9, 2012

It's ok with me, if you can do it

Collaborator

FiloSottile commented Oct 9, 2012

Oh. Be careful, your actual work is in a merge commit, and this make it really hard to rebase. Be careful to work always on clean states when you add some function. I'll try to fix it, but I don't know exactly how.

Contributor

danut007ro commented Oct 9, 2012

If someone manages to merge my changes that would be great. It would be awesome if that person posts a tutorial somewhere about how I should do it :)

Thanks

I can try to, but can't guarantee that I won't fail. ;D

Contributor

danut007ro commented Oct 9, 2012

Nevermind, I will close this and follow a tutorial.
Brb

@danut007ro danut007ro closed this Oct 9, 2012

^,^

Collaborator

FiloSottile commented Oct 9, 2012

<3 my tries were starting to be more and more exoteric... ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment