Add various anime download sites #4554

Closed
wants to merge 11 commits into
from

Conversation

Projects
None yet
4 participants
@AnonymousMeerkat

Soulanime, Gogoanime, and various sites that host anime (videofun, play44, byzoo, video44, videowing, playpanda, videozoo, playbb, easyvideo)

Let me know if anything needs to be changed if you wish to merge :)

@dstftw

This comment has been minimized.

Show comment
Hide comment
@dstftw

dstftw Dec 29, 2014

Collaborator

youtube-dl binary should be removed from the PR

Collaborator

dstftw commented Dec 29, 2014

youtube-dl binary should be removed from the PR

+ 'playlist_count': 3
+ }
+
+ def _real_extract(self, url):

This comment has been minimized.

@dstftw

dstftw Dec 29, 2014

Collaborator

Does not work for me:

> python -m youtube_dl -v http://www.gogoanime.com/mahou-shoujo-madoka-magica-movie-1
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['-v', 'http://www.gogoanime.com/mahou-shoujo-madoka-magica-movie-1']
[debug] Encodings: locale cp1251, fs mbcs, out None, pref cp1251
[debug] youtube-dl version 2014.12.17.2
[debug] Python version 2.7.6 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-68694-g7c210c4, ffprobe N-68694-g7c210c4, rtmpdump 2.3
[debug] Proxy map: {}
[gogoanime] mahou-shoujo-madoka-magica-movie-1: Downloading video page
[download] Downloading playlist: mahou-shoujo-madoka-magica-movie-1
[gogoanime] playlist mahou-shoujo-madoka-magica-movie-1: Collected 3 video ids (downloading 3 of them)
[download] Downloading video 1 of 3
[generic] a8d6a39522df066bd734a69f2334497e?w=600&h=438: Requesting header
WARNING: Falling back on generic information extractor.
[generic] a8d6a39522df066bd734a69f2334497e?w=600&h=438: Downloading webpage
[generic] a8d6a39522df066bd734a69f2334497e?w=600&h=438: Extracting information
ERROR: Unsupported URL: http://videowing.me/embed/a8d6a39522df066bd734a69f2334497e?w=600&h=438; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "youtube_dl\extractor\generic.py", line 660, in _real_extract
    doc = parse_xml(webpage)
  File "youtube_dl\utils.py", line 1444, in parse_xml
    tree = xml.etree.ElementTree.XML(s.encode('utf-8'), **kwargs)
  File "C:\Python27\lib\xml\etree\ElementTree.py", line 1300, in XML
    parser.feed(text)
  File "C:\Python27\lib\xml\etree\ElementTree.py", line 1642, in feed
    self._raiseerror(v)
  File "C:\Python27\lib\xml\etree\ElementTree.py", line 1506, in _raiseerror
    raise err
ParseError: not well-formed (invalid token): line 23, column 1861
Traceback (most recent call last):
  File "youtube_dl\YoutubeDL.py", line 592, in extract_info
    ie_result = ie.extract(url)
  File "youtube_dl\extractor\common.py", line 243, in extract
    return self._real_extract(url)
  File "youtube_dl\extractor\generic.py", line 1060, in _real_extract
    raise ExtractorError('Unsupported URL: %s' % url)
ExtractorError: Unsupported URL: http://videowing.me/embed/a8d6a39522df066bd734a69f2334497e?w=600&h=438; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
@dstftw

dstftw Dec 29, 2014

Collaborator

Does not work for me:

> python -m youtube_dl -v http://www.gogoanime.com/mahou-shoujo-madoka-magica-movie-1
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['-v', 'http://www.gogoanime.com/mahou-shoujo-madoka-magica-movie-1']
[debug] Encodings: locale cp1251, fs mbcs, out None, pref cp1251
[debug] youtube-dl version 2014.12.17.2
[debug] Python version 2.7.6 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-68694-g7c210c4, ffprobe N-68694-g7c210c4, rtmpdump 2.3
[debug] Proxy map: {}
[gogoanime] mahou-shoujo-madoka-magica-movie-1: Downloading video page
[download] Downloading playlist: mahou-shoujo-madoka-magica-movie-1
[gogoanime] playlist mahou-shoujo-madoka-magica-movie-1: Collected 3 video ids (downloading 3 of them)
[download] Downloading video 1 of 3
[generic] a8d6a39522df066bd734a69f2334497e?w=600&h=438: Requesting header
WARNING: Falling back on generic information extractor.
[generic] a8d6a39522df066bd734a69f2334497e?w=600&h=438: Downloading webpage
[generic] a8d6a39522df066bd734a69f2334497e?w=600&h=438: Extracting information
ERROR: Unsupported URL: http://videowing.me/embed/a8d6a39522df066bd734a69f2334497e?w=600&h=438; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "youtube_dl\extractor\generic.py", line 660, in _real_extract
    doc = parse_xml(webpage)
  File "youtube_dl\utils.py", line 1444, in parse_xml
    tree = xml.etree.ElementTree.XML(s.encode('utf-8'), **kwargs)
  File "C:\Python27\lib\xml\etree\ElementTree.py", line 1300, in XML
    parser.feed(text)
  File "C:\Python27\lib\xml\etree\ElementTree.py", line 1642, in feed
    self._raiseerror(v)
  File "C:\Python27\lib\xml\etree\ElementTree.py", line 1506, in _raiseerror
    raise err
ParseError: not well-formed (invalid token): line 23, column 1861
Traceback (most recent call last):
  File "youtube_dl\YoutubeDL.py", line 592, in extract_info
    ie_result = ie.extract(url)
  File "youtube_dl\extractor\common.py", line 243, in extract
    return self._real_extract(url)
  File "youtube_dl\extractor\generic.py", line 1060, in _real_extract
    raise ExtractorError('Unsupported URL: %s' % url)
ExtractorError: Unsupported URL: http://videowing.me/embed/a8d6a39522df066bd734a69f2334497e?w=600&h=438; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
+ return {}
+
+
+class GoGoAnimeSearchIE(InfoExtractor):

This comment has been minimized.

@dstftw

dstftw Dec 29, 2014

Collaborator

Same here.

@dstftw

dstftw Dec 29, 2014

Collaborator

Same here.

+
+from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,

This comment has been minimized.

@dstftw

dstftw Dec 29, 2014

Collaborator

Unused.

@dstftw

dstftw Dec 29, 2014

Collaborator

Unused.

+from ..utils import (
+ ExtractorError,
+ compat_urllib_parse
+)

This comment has been minimized.

@dstftw

dstftw Dec 29, 2014

Collaborator

Unused as well.

@dstftw

dstftw Dec 29, 2014

Collaborator

Unused as well.

+
+ vid = self._request_webpage(video_url, video_id)
+ #ext = vid.getheader("Content-Type").split("/")[1]
+ ext = vid.info().gettype().split("/")[1]

This comment has been minimized.

@dstftw

dstftw Dec 29, 2014

Collaborator

This does not work in python3.

@dstftw

dstftw Dec 29, 2014

Collaborator

This does not work in python3.

This comment has been minimized.

@phihag

phihag Jan 4, 2015

Collaborator

Fixed in 2ccd1b1.

@phihag

phihag Jan 4, 2015

Collaborator

Fixed in 2ccd1b1.

This comment has been minimized.

@dstftw

dstftw Jan 4, 2015

Collaborator

2ccd1b1

No such commit.

@dstftw

dstftw Jan 4, 2015

Collaborator

2ccd1b1

No such commit.

This comment has been minimized.

@phihag

phihag Jan 4, 2015

Collaborator

Pushed now; 2ccd1b1

@phihag

phihag Jan 4, 2015

Collaborator

Pushed now; 2ccd1b1

+from .common import InfoExtractor
+from ..utils import (
+ ExtractorError,
+ compat_urlparse,

This comment has been minimized.

@dstftw

dstftw Dec 29, 2014

Collaborator

Unused.

@dstftw

dstftw Dec 29, 2014

Collaborator

Unused.

@dstftw

This comment has been minimized.

Show comment
Hide comment
@dstftw

dstftw Dec 29, 2014

Collaborator

Thanks for your PR, we appreciate your effort.
These are just some of the issues found after a quick look. It also would be great if you split this PR in multiple PRs per extractor as it's much easier for review and work with.

Collaborator

dstftw commented Dec 29, 2014

Thanks for your PR, we appreciate your effort.
These are just some of the issues found after a quick look. It also would be great if you split this PR in multiple PRs per extractor as it's much easier for review and work with.

@AnonymousMeerkat

This comment has been minimized.

Show comment
Hide comment
@AnonymousMeerkat

AnonymousMeerkat Dec 29, 2014

Alright, I'll fix these! =D

Alright, I'll fix these! =D

@jaimeMF

This comment has been minimized.

Show comment
Hide comment
@jaimeMF

jaimeMF Dec 31, 2014

Collaborator

Do all those sites have the rights for distributing the content?

Collaborator

jaimeMF commented Dec 31, 2014

Do all those sites have the rights for distributing the content?

@phihag phihag closed this in b68ff25 Jan 4, 2015

@phihag

This comment has been minimized.

Show comment
Hide comment
@phihag

phihag Jan 4, 2015

Collaborator

As pointed out by @jaimeMF, these sites may not have the legal rights to distribute their content.

gogoanime

According to http://www.gogoanime.com/private-policy , they did not acquire anything, and indeed, they only redirect.

However, the test URL refers to content that is - according to Wikipedia copyrighted way too recently to have become part of the public domain (2011). I cannot find any licensing that would allow public distribution.

For the above reasons, I have removed the test. Since the gogoanime extractor is now without a valid test case, I have removed it as well.

play44

play44 claims that they don't host the videos in a link on their main sites. This does not seem to be true:

$ youtube-dl -g test:play44
http://gateway.play44.net/videos/M/mahou-shoujo-madoka-magica-07.flv?st=5myTWm-VXyXTNz0XLvHWTA&e=1420401773&server=play44

The example URL refers to the same copyrighted series. The example URLs for the other play44-derived extractors seem to refer to another series copyrighted in 2011, of which I cannot find any licensing that would allow public distribution.

Therefore, I have removed the test cases and hence the extractors related to play44.

soulanime

soulanime claims that they don't the content as well, but that does not seem to be true:

$ youtube-dl test:soulanime:watching -g
http://www.soul-anime.net/downloads/seirei-tsukai-no-blade-dance-episode-9/

The test URL seems to refer to content that has been copyrighted in 2014. Again, I fail to find any public domain or even a free dedication.

Therefore, I have removed the test case. Since the soulanime extractor is now without a valid test case, I have removed the extractor as well.

videofun

videofun.me is somewhat surprising in that they don't seem to have any content on their front page. Looking at the code, I see references to anime44 though, which is probably related to play44. Our test URL seems to refer to the same content as the one for play44.

Therefore, I have removed the test case. Since the videofun extractor is now without a valid test case, I have removed the extractor as well.

Readding these sites

If you do think that these sites do have permission to distribute their content, please provide hints that they do, and example URLs where it's obvious that the uploader had rights to distribute the content, and has transferred those to the video service. As it stands, it looks like all of these sites infringe copyright, and are therefore not fit to be included in youtube-dl.

Collaborator

phihag commented Jan 4, 2015

As pointed out by @jaimeMF, these sites may not have the legal rights to distribute their content.

gogoanime

According to http://www.gogoanime.com/private-policy , they did not acquire anything, and indeed, they only redirect.

However, the test URL refers to content that is - according to Wikipedia copyrighted way too recently to have become part of the public domain (2011). I cannot find any licensing that would allow public distribution.

For the above reasons, I have removed the test. Since the gogoanime extractor is now without a valid test case, I have removed it as well.

play44

play44 claims that they don't host the videos in a link on their main sites. This does not seem to be true:

$ youtube-dl -g test:play44
http://gateway.play44.net/videos/M/mahou-shoujo-madoka-magica-07.flv?st=5myTWm-VXyXTNz0XLvHWTA&e=1420401773&server=play44

The example URL refers to the same copyrighted series. The example URLs for the other play44-derived extractors seem to refer to another series copyrighted in 2011, of which I cannot find any licensing that would allow public distribution.

Therefore, I have removed the test cases and hence the extractors related to play44.

soulanime

soulanime claims that they don't the content as well, but that does not seem to be true:

$ youtube-dl test:soulanime:watching -g
http://www.soul-anime.net/downloads/seirei-tsukai-no-blade-dance-episode-9/

The test URL seems to refer to content that has been copyrighted in 2014. Again, I fail to find any public domain or even a free dedication.

Therefore, I have removed the test case. Since the soulanime extractor is now without a valid test case, I have removed the extractor as well.

videofun

videofun.me is somewhat surprising in that they don't seem to have any content on their front page. Looking at the code, I see references to anime44 though, which is probably related to play44. Our test URL seems to refer to the same content as the one for play44.

Therefore, I have removed the test case. Since the videofun extractor is now without a valid test case, I have removed the extractor as well.

Readding these sites

If you do think that these sites do have permission to distribute their content, please provide hints that they do, and example URLs where it's obvious that the uploader had rights to distribute the content, and has transferred those to the video service. As it stands, it looks like all of these sites infringe copyright, and are therefore not fit to be included in youtube-dl.

naglis pushed a commit that referenced this pull request Feb 8, 2015

Naglis Jonaitis
[soulanime] Remove extractor (#4554)
Was supposed to be deleted by 67c2bcd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment