only retry a few times

rgaidot · May 6, 2010 · 5727d32 · 5727d32
1 parent e272d32
commit 5727d32
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/lib/facebook-graphclient.rb b/lib/facebook-graphclient.rb
@@ -47,12 +47,15 @@ def api action, method, query_params = nil
 
       query_string = '?' + query_params.map { |k,v| "#{k}=#{v}" }.join("&") unless query_params.empty?
 
+      tries = 0
       begin
         raw_response = @session.send(action, GRAPH_URL + method + query_string)
       rescue Patron::HostResolutionError
-        retry
+        retry if tries < 5
+        tries += 1
       rescue Patron::ConnectionFailed
-        retry
+        retry if tries < 5
+        tries += 1
       end
 
       # TODO: Handle photo requests, which return photo data and not JSON
@@ -80,12 +83,15 @@ def fql query
 
       query_string = '?' + query_params.map { |k,v| "#{k}=#{v}" }.join("&") unless query_params.empty?
 
+      tries = 0
       begin
         raw_response = @session.get("https://api.facebook.com/method/fql.query" + query_string)
       rescue Patron::HostResolutionError
-        retry
+        retry if tries < 5
+        tries += 1
       rescue Patron::ConnectionFailed
-        retry
+        retry if tries < 5
+        tries += 1
       end
 
       response = Yajl::Parser.parse(raw_response.body)