Progress bar #17

Merged
merged 2 commits into from Apr 5, 2012

Projects

None yet

2 participants

@yonran
Contributor
yonran commented Mar 31, 2012

Adds a progress bar in addition to the spinner when loading the 2–10MB json files. For those browsers that support XMLHttpRequest 2.0 progress events and the progress element. Here’s how it looks:

screenshot

@rgarcia rgarcia merged commit bc2bab8 into rgarcia:master Apr 5, 2012
@rgarcia
Owner
rgarcia commented Apr 5, 2012

really cool! thanks for contributing.

@rgarcia
Owner
rgarcia commented Apr 5, 2012

so I just noticed when clicking on multiple links in succession this kind of looks weird:

screenshot

you can play around with it here: http://instacss-staging.herokuapp.com

@yonran
Contributor
yonran commented Apr 5, 2012

hmm You're right, it's weird to see multiple spinners and bars. I'll have to try it out some more to see what's going on (e.g. when one of them finishes, do the results get drawn while the second one is still spinning?).

@rgarcia
Owner
rgarcia commented Apr 13, 2012

I'm leaning towards rolling this change back, since I'd like to push out the other updates...

@yonran
Contributor
yonran commented Apr 14, 2012

Sure thing; it was relatively minor change. Don't keep us waiting on what you're working on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment