Link bugfixes and minor changes. #19

merged 7 commits into from Apr 13, 2012


None yet
2 participants

yonran commented Apr 11, 2012

I added a bad bug in the last pull request: the router no longer recognized links with queries! This pull request fixes that bug and also makes search results actual links that can be Ctrl-clicked.

yonran added some commits Apr 6, 2012

Fix the route regexp (I accidentally broke links to sections).
Revision "Draw topnav even when the user navigates to #css or #css/."
broke routes with queries.
Make the tocresult links have hrefs, and handler ignores click with m…

By setting href, the search result links are now keyboard-accessible.
Also, the click handler now ignores right-click and Ctrl-click
(Cmd-click) so the user can open the link in a new tab.

In order to calculate the fragment, languageview must pass languageName
to searchresults, which passes it to mozdevcssprop. Similarly,
pagescrapedlanguageview sends languageName to pagesearchresults, which
sends it to mozdevcssprop to render..
Add bootstrap-collapse which is used by the button in the navbar.
When the document width is small, bootstrap-responsive.css collapses the
navbar and you have to click the button with data-toggle="collapse"
expand it again. This behavior requires bootstrap-collapse.js to work.
Rename lowerCaseName -> lowerCaseTitle within models/pageelement.js.
This makes the terminology a bit simpler. The fragment for a result is
always #lowerCaseLanguageName/lowerCaseTitle.
Change pagesearchresults to ignore right-click etc.
I forgot to include this change with "Make the tocresult links have
hrefs, and handler ignores click with modifier".

rgarcia commented Apr 13, 2012

looks good to me. thanks a ton!

rgarcia added a commit that referenced this pull request Apr 13, 2012

Merge pull request #19 from yonran/minor-link-changes
Link bugfixes and minor changes.

@rgarcia rgarcia merged commit fe90484 into rgarcia:master Apr 13, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment