New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PropTypes from prop-types package instead of React.PropTypes #41

Merged
merged 1 commit into from Sep 22, 2017

Conversation

Projects
None yet
2 participants
@mleduque
Contributor

mleduque commented Sep 22, 2017

Hello,
I recent versions of react, the PropTypes property was removed, and this module stopped working (I was interested in withNetworkConnectivity for example).
Would you mind releasing a version with this change which uses the external 'prop-types' package as source for PropTypes ?

@rgommezz rgommezz merged commit 1ac1e22 into rgommezz:master Sep 22, 2017

@rgommezz

This comment has been minimized.

Show comment
Hide comment
@rgommezz

rgommezz Sep 22, 2017

Owner

New version released, thanks! :)

Owner

rgommezz commented Sep 22, 2017

New version released, thanks! :)

@mleduque

This comment has been minimized.

Show comment
Hide comment
@mleduque

mleduque Sep 22, 2017

Contributor

I'd say "you're welcome", but I'm actually grateful. Thanks!

Contributor

mleduque commented Sep 22, 2017

I'd say "you're welcome", but I'm actually grateful. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment