New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for private repositories #62

Closed
mitar opened this Issue Apr 23, 2015 · 5 comments

Comments

3 participants
@mitar

mitar commented Apr 23, 2015

When I access a private raw file in GitHub, GitHub appends a token to the URL so that one can acess it:

https://raw.githubusercontent.com/...?token=...

When I open rawgit URL I get 404. :-(

It seems token is not used/passed on?

I would need this to be able to add SVG images to the README in a private repository.

@rgrove

This comment has been minimized.

Show comment
Hide comment
@rgrove

rgrove Apr 23, 2015

Owner

Sorry, private repos are intentionally not supported because I don't want peoples' tokens flowing through RawGit (or the CDN). That's too much scary responsibility!

Feel free to fork RawGit and run a private instance that adds that functionality though.

Owner

rgrove commented Apr 23, 2015

Sorry, private repos are intentionally not supported because I don't want peoples' tokens flowing through RawGit (or the CDN). That's too much scary responsibility!

Feel free to fork RawGit and run a private instance that adds that functionality though.

@mitar

This comment has been minimized.

Show comment
Hide comment
@mitar

mitar Apr 23, 2015

Oh. But you could just display a warning once somebody pastes in a link with a token? No? That this is insecure. And aren't tokens per-file anyway?

Hm, you could at least display an error in this case. And not strange 404.

mitar commented Apr 23, 2015

Oh. But you could just display a warning once somebody pastes in a link with a token? No? That this is insecure. And aren't tokens per-file anyway?

Hm, you could at least display an error in this case. And not strange 404.

@rgrove

This comment has been minimized.

Show comment
Hide comment
@rgrove

rgrove Apr 23, 2015

Owner

Good idea. I'll consider adding a special error.

Owner

rgrove commented Apr 23, 2015

Good idea. I'll consider adding a special error.

@duttaditya18

This comment has been minimized.

Show comment
Hide comment
@duttaditya18

duttaditya18 Jan 17, 2018

@rgrove Any plans for this?

duttaditya18 commented Jan 17, 2018

@rgrove Any plans for this?

@rgrove

This comment has been minimized.

Show comment
Hide comment
@rgrove

rgrove Jan 17, 2018

Owner

Still no plans to support private repos. Especially now, since people have recently been trying to use RawGit to distribute malware. The last thing I need is malware hosted in a private repo that I can't see.

Owner

rgrove commented Jan 17, 2018

Still no plans to support private repos. Especially now, since people have recently been trying to use RawGit to distribute malware. The last thing I need is malware hosted in a private repo that I can't see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment