Ralf Haferkamp rhafer

  • Germany
  • Joined on

Organizations

@openSUSE @SUSE-Cloud @crowbar
rhafer commented on pull request crowbar/barclamp-neutron#220
@rhafer

I tested at least the non-DVR part. That looks good.

rhafer opened pull request crowbar/barclamp-neutron#220
@rhafer
Only install metadata-agent where needed
1 commit with 44 additions and 42 deletions
rhafer commented on pull request crowbar/barclamp-nova_dashboard#216
@rhafer

Something is a bit weird here. To me it seems the versioned_service_URL and service_URL helpers where never really meant to be called from other co…

rhafer commented on pull request crowbar/barclamp-nova_dashboard#216
@rhafer

Same here. You can get the service port via keystone_settings['service_port']

rhafer commented on pull request crowbar/barclamp-nova_dashboard#216
@rhafer

You'd want to use the fqdn of the keystone node here that's available via: keystone_settings['internal_url_host']

rhafer commented on pull request crowbar/barclamp-nova_dashboard#216
@rhafer

I think you need to pass the node object of the node running keystone here. If you deploy the dashboard and keystone on different nodes node will p…

rhafer commented on pull request crowbar/barclamp-nova_dashboard#216
@rhafer

BTW, it seems this needs a rebase. (doesn't currently merge)

rhafer commented on pull request crowbar/barclamp-keystone#272
@rhafer

Same here

rhafer commented on pull request crowbar/barclamp-keystone#272
@rhafer

The new attribute is ['api']['version'] not ['version'].

rhafer commented on pull request crowbar/barclamp-nova_dashboard#216
@rhafer

AFAICS you'd need to pass v3 here otherwise the keystonehelper will return the wrong uri.

rhafer commented on pull request crowbar/barclamp-nova_dashboard#216
@rhafer

Typo: KeystobeHerper

rhafer commented on pull request crowbar/barclamp-keystone#272
@rhafer

Is that new version parameter still required? Looks like if this is not used anywhere.

rhafer commented on pull request crowbar/barclamp-keystone#272
@rhafer

I don't think this is the right approach for introducing multidomain support. First the V3 API can be used of much more things that just multi doma…

@rhafer
@rhafer
Add domain_id also for get_user_by_name
1 commit with 3 additions and 1 deletion
rhafer commented on pull request crowbar/barclamp-ipmi#101
@rhafer

+1

@rhafer
@rhafer
crowbar_register: Fix error message for hostname test
1 commit with 1 addition and 1 deletion
rhafer commented on pull request crowbar/barclamp-provisioner#411
@rhafer

+1

@rhafer
@rhafer
Improve keep_existing_hostname handling in crowbar_register
1 commit with 15 additions and 6 deletions
rhafer commented on pull request crowbar/barclamp-ipmi#101
@rhafer

Hm, actuall the ipmitool man page recommends this for probing the lan channel: NOTE: To determine on which channel the LAN interface is located, is…

rhafer commented on pull request crowbar/barclamp-ipmi#101
@rhafer

Hm, is 1..14 really correct here? I don't know, as I have very limited IPMI knowledge. But https://www.thomas-krenn.com/en/wiki/IPMI_Basics#Channel…

rhafer commented on pull request crowbar/barclamp-dns#133
@rhafer

+1, works for me.

rhafer commented on pull request crowbar/barclamp-dns#133
@rhafer

s/proposal["attributes"]/role.override_attributes/

@rhafer
@rhafer
Fix useradd call for SLE11 (bsc#928931)
1 commit with 1 addition and 1 deletion
rhafer commented on pull request crowbar/barclamp-provisioner#403
@rhafer

Looks good to me. A somewhat more descriptive commit message (what are the improvements?) would be helpful though. But I am fine with merging this …

@rhafer

Please make this attribute required.