Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoconf/automake #5

Closed
wants to merge 5 commits into from
Closed

autoconf/automake #5

wants to merge 5 commits into from

Conversation

0-wiz-0
Copy link
Contributor

@0-wiz-0 0-wiz-0 commented Feb 16, 2014

Hi!
I've added autoconf/automake support to rhash. The main motivation was a properly libtoolized librhash, since other projects are using the library.
As the commit log says, there are some open points, which I can't address, I hope you can work on those:
Some of the custom targets were not ported (RPM, Debian package, other binary distribution files).
Windows support needs to be re-done, I can't test that.

gettext and bindings/ support could also be improved, but my first try for gettext was a lot of effort and went nowhere, so I'd like to know if you're interested in the autoconf project at all before continuing.

I hope you find this useful.
Thomas

0-wiz-0 and others added 5 commits February 16, 2014 12:07
Use autoconf and automake for building the library and the executables.
Use libtool to build the library.
Add support for choosing sysconfdir ("/etc/").
Auto-detect openssl.
Add some files requested by autoconf/automake (AUTHORS, NEWS).
Replace the manual INSTALL file with the default one from auto*.
Update patterns in .gitignore.

'make distcheck' finishes without problems for me.

TODO:
Some of the custom targets were not ported (RPM, Debian package,
other binary distribution files).
Windows support needs to be re-done, I can't test that.
gettext is not properly auto-detected.
Better support for bindings/ could be added.
Matches current uTorrent algorithm.
@rhash
Copy link
Owner

rhash commented Apr 18, 2014

Hello Thomas,
thanks for the interest in RHash. :)

My vision of the project development is a bit different.
I want to minimize compilation dependendencies. Instead of using
autoconf/automake, I want to write a ./configure script by hands, the
same way as the MPlayer project have done.

I understand that you've done a big work. Sorry, that I personally
dislike autoconf.

In spite of this, it's ok with me to place some files in a
sub-directory of the rhash repository (not in the root), if it can
somehow simplify building of autoconf-based projects which use LibRHash [1].

Best regards,
Aleksey.

[1] http://sourceforge.net/apps/mediawiki/rhash/index.php?title=LibRHash

16.02.2014 18:21, Thomas Klausner wrote:

Hi!
I've added autoconf/automake support to rhash. The main motivation was a
properly libtoolized librhash, since other projects are using the library.
As the commit log says, there are some open points, which I can't
address, I hope you can work on those:
Some of the custom targets were not ported (RPM, Debian package, other
binary distribution files).
Windows support needs to be re-done, I can't test that.

gettext and bindings/ support could also be improved, but my first try
for gettext was a lot of effort and went nowhere, so I'd like to know if
you're interested in the autoconf project at all before continuing.

I hope you find this useful.
Thomas


    You can merge this Pull Request by running

git pull https://github.com/0-wiz-0/RHash master

Or view, comment on, or merge it at:

#5

    Commit Summary


Reply to this email directly or view it on GitHub
#5.

@0-wiz-0
Copy link
Contributor Author

0-wiz-0 commented Apr 18, 2014

Thank you for your reply.
What a pity that you don't like autoconf...

Adding the autoconf stuff looks like this:
One configure.ac in the toplevel
One Makefile.am in each directory.
Sadly, you can't put the files somewhere else.

People wanting to use it would just install automake & autoconf and run 'autoreconf -fiv' at the toplevel and then the usual ./configure && make && make install.

I hope that's ok with you even if you don't like autoconf?

@rhash
Copy link
Owner

rhash commented Apr 24, 2014

No, sorry. I can't stand .ac/.am files in the top directory :)

19.04.2014 5:04, Thomas Klausner wrote:

Thank you for your reply.
What a pity that you don't like autoconf...

Adding the autoconf stuff looks like this:
One configure.ac in the toplevel
One Makefile.am in each directory.
Sadly, you can't put the files somewhere else.

People wanting to use it would just install automake & autoconf and run
'autoreconf -fiv' at the toplevel and then the usual ./configure && make
&& make install.

I hope that's ok with you even if you don't like autoconf?


Reply to this email directly or view it on GitHub
#5 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants