Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitBook svg #67

Merged
merged 1 commit into from Oct 17, 2019

Conversation

@davidfeng88
Copy link

davidfeng88 commented Oct 16, 2019

First, I really like this theme! However, feather icons does not have an icon for GitBook (https://feathericons.com/?query=gitbook).

I Ripped the svg from GitBook's website (http://styleguide.gitbook.com/icons), adjusted width/height/viewBox. Note that the width is larger than the height. To keep the height consistent with other icons (24), the width is set to 33.

Also although other feather icon svg use stroke, due to the nature of the svg, I chose to use the original style from GitBook's website (fill with currentColor).

Screenshot from my website: https://davidfeng.us/

GitBook svg

@rhazdon

This comment has been minimized.

Copy link
Owner

rhazdon commented Oct 17, 2019

Hi @davidfeng88, thank you very much! It looks awesome. :)

@rhazdon rhazdon merged commit 6cdbc10 into rhazdon:master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.