New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fwup_set_up_update possibly needs fflush and fsync #46

Closed

superm1 opened this issue Mar 4, 2016 · 1 comment

Collaborator

superm1 commented Mar 4, 2016

Another review happened in Ubuntu recently (https://bugs.launchpad.net/ubuntu/+source/fwupdate/+bug/1508926/comments/7) and one question was put forward that should be double checked:

fwup_set_up_update() lots of work between final fputc() and fclose() --
  does this need fflush(fout); fsync(outfd); before the work?

The remaining items from the review that were applicable are submitted in a pull request here: https://github.com/rhinstaller/fwupdate/pull/45/commits

The text was updated successfully, but these errors were encountered:

vathpela closed this as completed in

b8df6bf

Contributor

vathpela commented Mar 23, 2016

We don't need fflush(), as fclose() is defined as doing that, but we do need fsync() before we close the file. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment