Fix fwupx64.efi not actually staging capsules properly. (#80) #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bisecting master shows that the problem was introduced in 6f63cdd.
When the guid_cmp comparison was put in place it flipped the logic
of one of the checks.
git bisect start 'efi/'
bad: [5c2a8d0] efi: better debugging on our capsule tests.
git bisect bad 5c2a8d0
good: [04daa63] Make SUBDIRS overrideable
git bisect good 04daa63
good: [cd9ea4c] efi: delete the boot path from the BootOrder list
git bisect good cd9ea4c
good: [515b0c0] Fix capsule sizes for our ux image capsules
git bisect good 515b0c0
bad: [6f63cdd] efi: Add guid_cmp() and remove manual comparisons.
git bisect bad 6f63cdd
good: [55ed685] Reorganize Make.version a bit so "bumpver" works better.
git bisect good 55ed685
good: [75391bc] Adding capsule headers should add flags if it's /not/ a ux cap.
git bisect good 75391bc
first bad commit: [6f63cdd] efi: Add guid_cmp() and remove manual comparisons.