dnfpayload: do not try to contact disabled repo (#1470552) #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes a regression introduced by: 79e66d2 Fix Anaconda forces payload restart when network (not)change (#1373449) When anaconda tries to build the repositories MD5 cache, it mistakenly iterates over all the repositories it is aware about, ever the disabled ones. The end result is that it tries to reach the default disabled repositories from "/etc/anaconda.repos.d/", for example "https://codecs.fedoraproject.org/openh264/$releasever/$basearch/". If the user is in a private intranet and the internet is not reachable, this may lead to very long delays related to long dnf timeouts. The fix is to only build the MD5 cache for the enabled repositories and leave the disabled ones alone. Resolves: rhbz#1470552 Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
dedekind
changed the title
poncovka
approved these changes
Aug 13, 2017
M4rtinK
approved these changes
Aug 14, 2017
|
Thank you much for this patch 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a regression introduced by:
79e66d2 Fix Anaconda forces payload restart when network (not)change (#1373449)
When anaconda tries to build the repositories MD5 cache, it mistakenly
iterates over all the repositories it is aware about, ever the disabled ones.
The end result is that it tries to reach the default disabled repositories from
"/etc/anaconda.repos.d/", for example
"https://codecs.fedoraproject.org/openh264/$releasever/$basearch/".
If the user is in a private intranet and the internet is not reachable, this
may lead to very long delays related to long dnf timeouts.
The fix is to only build the MD5 cache for the enabled repositories and leave
the disabled ones alone.
Resolves Fedora bug #1470552 in the RedHat bugzilla.
Signed-off-by: Artem Bityutskiy artem.bityutskiy@linux.intel.com