New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master: kickstart: support firewall --use-system-defaults #1271

Merged
merged 1 commit into from Jan 5, 2018

Conversation

Projects
None yet
5 participants
@dustymabe
Contributor

dustymabe commented Dec 15, 2017

Needed for [1] where we would like to include firewalld
and configure firewalld in Atomic Host (in the ostree) and
have Anaconda leave the delivered "defaults" in place. The
action here is to do nothing if the user specified
--use-system-defaults.

[1] https://pagure.io/atomic-wg/issue/401

@dustymabe

This comment has been minimized.

Contributor

dustymabe commented Dec 15, 2017

related to: dcantrell/pykickstart#203

I did not test this one thoroughly like I did the patches to to the f27 branches because the transition to pykickstart 3 hasn't happened yet. I will make sure to be involved when that happens in rawhide.

@dustymabe dustymabe force-pushed the dustymabe:master branch from cf31311 to d285708 Dec 15, 2017

@cgwalters

This comment has been minimized.

Contributor

cgwalters commented Dec 15, 2017

Seems sane to me.

@dustymabe dustymabe force-pushed the dustymabe:master branch from d285708 to e886d67 Dec 15, 2017

@rvykydal

Looks good to me.

@rvykydal rvykydal added the master label Dec 18, 2017

@M4rtinK

Looks good to me as well.

@rvykydal

This comment has been minimized.

Contributor

rvykydal commented Dec 18, 2017

We should also increment required pykickstart version in anaconda.spec.in

@jkonecny12

This comment has been minimized.

Contributor

jkonecny12 commented Dec 18, 2017

Jenkins, it's ok to test.

@jkonecny12

Looks good to me.

@jkonecny12

This comment has been minimized.

Contributor

jkonecny12 commented Dec 18, 2017

Tests are failing because of missing F28_Firewall class.

@dustymabe

This comment has been minimized.

Contributor

dustymabe commented Dec 18, 2017

Tests are failing because of missing F28_Firewall class.

so we need to wait for the new pykickstart first?

@jkonecny12

This comment has been minimized.

Contributor

jkonecny12 commented Dec 19, 2017

Yes we should wait for pykickstart first, otherwise we would be blocked to make a new release and all the tests will be failing.

@dustymabe dustymabe force-pushed the dustymabe:master branch from e886d67 to a42a4ad Jan 3, 2018

@dustymabe

This comment has been minimized.

Contributor

dustymabe commented Jan 3, 2018

the pykickstart PR for master was merged

@jkonecny12

Could you increase pykickstart version in the spec file please.

@jkonecny12

This comment has been minimized.

Contributor

jkonecny12 commented Jan 4, 2018

jenkins, test this please

kickstart: support firewall --use-system-defaults (#1526450)
Needed for [1] where we would like to include firewalld
and configure firewalld in Atomic Host (in the ostree) and
have Anaconda leave the delivered "defaults" in place. The
action here is to do nothing if the user specified
--use-system-defaults.

[1] https://pagure.io/atomic-wg/issue/401

Resolves: rhbz#1526450

@dustymabe dustymabe force-pushed the dustymabe:master branch from a42a4ad to 8d06406 Jan 4, 2018

@dustymabe

This comment has been minimized.

Contributor

dustymabe commented Jan 4, 2018

Could you increase pykickstart version in the spec file please.

I'm guessing the version will be %define pykickstartver 2.44-1. rebased and added that.

@jkonecny12

Yes it should be fine. Thanks!

And now we need to wait till new pykickstart version will be released. After that this PR can be merged and new Anaconda released.

@dustymabe

This comment has been minimized.

Contributor

dustymabe commented Jan 4, 2018

And now we need to wait till new pykickstart version will be released. After that this PR can be merged and new Anaconda released.

@clumens ^^ FYI

@jkonecny12 - note that the commits from the other branches have (cherry picked from commit 8d06406) messages in them. I'm not sure if merging will preserve the commit hash or not, so let's be careful when we do merge this set of PRs. I'll rebase the other two branches if needed.

@dustymabe

This comment has been minimized.

@jkonecny12

This comment has been minimized.

Contributor

jkonecny12 commented Jan 5, 2018

jenkins, test this please

@jkonecny12

This comment has been minimized.

Contributor

jkonecny12 commented Jan 5, 2018

@jkonecny12 - note that the commits from the other branches have (cherry picked from commit 8d06406) messages in them. I'm not sure if merging will preserve the commit hash or not, so let's be careful when we do merge this set of PRs. I'll rebase the other two branches if needed.

I think it should be fine for Fedora. The only potential problem I can think of is bugzilla connection to bugs but that is done by Bodhi which should look on the correct branch and isn't enabled on Rawhide.

@jkonecny12 jkonecny12 merged commit 2d73296 into rhinstaller:master Jan 5, 2018

2 checks passed

Anaconda Rawhide test install Build finished.
Details
Anaconda Rawhide tests Build finished.
Details

dustymabe added a commit to dustymabe/rpm-ostree-toolbox that referenced this pull request Jan 12, 2018

installer: tell anaconda to leave firewall alone
Take advantage of `firewall --use-system-defaults` [1]
so that we can embed firewalld [2] but leave it disabled.

[1] rhinstaller/anaconda#1271
[2] https://pagure.io/fedora-atomic/pull-request/103

dustymabe added a commit to dustymabe/rpm-ostree-toolbox that referenced this pull request Jan 12, 2018

installer: tell anaconda to leave firewall alone
Take advantage of `firewall --use-system-defaults` [1]
so that we can embed firewalld [2] but leave it disabled.
This was done in fedora lorax templates as well [3].

[1] rhinstaller/anaconda#1271
[2] https://pagure.io/fedora-atomic/pull-request/103
[3] https://pagure.io/fedora-lorax-templates/pull-request/25

jlebon added a commit to projectatomic/rpm-ostree-toolbox that referenced this pull request Jan 12, 2018

installer: tell anaconda to leave firewall alone
Take advantage of `firewall --use-system-defaults` [1]
so that we can embed firewalld [2] but leave it disabled.
This was done in fedora lorax templates as well [3].

[1] rhinstaller/anaconda#1271
[2] https://pagure.io/fedora-atomic/pull-request/103
[3] https://pagure.io/fedora-lorax-templates/pull-request/25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment