Set the VNC password directly (#1592686) #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkonecny12
requested changes
Sep 21, 2018
pyanaconda/vnc.py
Outdated
|
|
||
| return rc | ||
| if proc.returncode != 0: | ||
| raise OSError("Unable to set the VNC password.") |
There was a problem hiding this comment.
You should also log stderr in this case please if possible.
The vncpasswd tool was waiting for an input from a pipe, because the file descriptor for writing wasn't closed. Let's not use pipes at all. We can use the input argument of the communicate method instead. Resolves: rhbz#1592686
poncovka
force-pushed
the
f29-devel-vnc_password
branch
from
7b5270f
to
de88ab5
Compare
|
Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vncpasswd tool was waiting for an input from a pipe, because the
file descriptor for writing wasn't closed. Let's not use pipes at all.
We can use the input argument of the communicate method instead.
Resolves: rhbz#1592686