Set default entry to the BLS id instead of the entry index #1789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkonecny12
added
rhel-devel
manual testing required
|
Jenkins, test this please. |
jkonecny12
approved these changes
Jan 31, 2019
|
@jkonecny12 thanks, fixed the typo now. |
poncovka
approved these changes
Feb 1, 2019
poncovka
removed
the
manual testing required
|
@martinezjavier could you rebase this pull request to the |
The GRUB default boot entry is set to the default's entry index. This made sense on a non-BLS configuration because the entries where defined in the GRUB config file, so they had a strict definition order. But that's not the case on a BLS configuration, users can add or remove an entry by just dropping or removing files from the /boot/loader/entries dir. That means the default won't necessary be the installed kernel, but rather the BLS that's first in the sorted list of BLS snippets. So instead the default entry should be explicit and set to the BLS id of the default kernel (the machine ID followed by a dash and kernel version). That is also what is used when a new kernel is installed, so the initial grubenv should be consistent. Resolves: rhbz#1671047 Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
|
@poncovka done |
|
Jenkins, test this please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GRUB default boot entry is set to the default's entry index. This made
sense on a non-BLS configuration because the entries where defined in the
GRUB config file, so they had a strict definition order.
But that's not the case on a BLS configuration, users can add or remove an
entry by just dropping or removing files from the /boot/loader/entries dir.
That means the default won't necessary be the installed kernel, but rather
the BLS that's first in the sorted list of BLS snippets.
So instead the default entry shold be explicit and be set to the BLS id of
the default kernel (the machine ID followed by a dash and kernel version).
That is also what is used when a new kernel is installed, so the initial
grubenv should be consistent.
Resolves: rhbz#1671047
Signed-off-by: Javier Martinez Canillas javierm@redhat.com