Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: pass also keyfile NM configuration to target system (#1858439) #2775

Merged

Conversation

rvykydal
Copy link
Contributor

@rvykydal rvykydal commented Aug 7, 2020

No description provided.

@rvykydal rvykydal added the master Please, use the `f39` label instead. label Aug 7, 2020
@rvykydal
Copy link
Contributor Author

rvykydal commented Aug 7, 2020

This is just a start of support for NM keyfiles in Anaconda and unblocking of some of Adam's tests. The plan is that Anaconda would be able to handle both at the same time (as NM is), but the direct handling (reading/writing) of NM config files would be drastically reduced (to none ideally) and replaced by using NM API and its configuration objects.

Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@poncovka poncovka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rvykydal rvykydal merged commit 7a78f5b into rhinstaller:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master Please, use the `f39` label instead.
3 participants