Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the DBus method IsDeviceShrinkable (#1875677) #2836

Merged
merged 1 commit into from Sep 9, 2020
Merged

Add the DBus method IsDeviceShrinkable (#1875677) #2836

merged 1 commit into from Sep 9, 2020

Conversation

poncovka
Copy link
Contributor

@poncovka poncovka commented Sep 7, 2020

Replace the DBus method IsDeviceResizable with IsDeviceShrinkable and fix its
implementation. A shrinkable device has to be resizable and its minimal size
has to be lower then the current size. This should fix the issue with XFS, that
is resizable, but not shrinkable.

Resolves: rhbz#1875677

@poncovka
Add the DBus method IsDeviceShrinkable (#1875677)
cf8d381 
Replace the DBus method IsDeviceResizable with IsDeviceShrinkable and fix its
implementation. A shrinkable device has to be resizable and its minimal size
has to be lower then the current size. This should fix the issue with XFS, that
is resizable, but not shrinkable.

Resolves: rhbz#1875677
@poncovka poncovka added master Please, use the `f39` label instead. f33 labels Sep 7, 2020
VladimirSlavik
VladimirSlavik approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

(Does this mean we assume all devices are growable?)

@poncovka
Copy link
Contributor Author

poncovka commented Sep 8, 2020

(Does this mean we assume all devices are growable?)

This change affects only DBus support for the resize dialog. In this dialog, devices can be shrunken or removed, so it doesn't matter whether they are growable. We don't really care.

M4rtinK
M4rtinK approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well. :)

@poncovka poncovka merged commit bdf3c61 into rhinstaller:f33-devel Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M4rtinK M4rtinK M4rtinK approved these changes

@VladimirSlavik VladimirSlavik VladimirSlavik approved these changes

Assignees
No one assigned
Labels
f33 master Please, use the `f39` label instead.
Milestone
No milestone
3 participants
@poncovka @M4rtinK @VladimirSlavik