Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ovirt: move /var/tmp to its own partition #3888

Merged
merged 1 commit into from Mar 10, 2022
Merged

ovirt: move /var/tmp to its own partition #3888

merged 1 commit into from Mar 10, 2022

Conversation

sandrobonazzola
Copy link
Contributor

@sandrobonazzola sandrobonazzola commented Feb 23, 2022 •
edited

Move /var/tmp and /var/crash to their own partition on oVirt and RHV for DISA-STIG support.

As CentOS Linux gone EOL, switching oVirt to CentOS Stream

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2057475
Signed-off-by: Sandro Bonazzola sbonazzo@redhat.com

@sandrobonazzola
Copy link
Contributor Author

@poncovka , @M4rtinK can you please review?

@sandrobonazzola sandrobonazzola mentioned this pull request Feb 23, 2022
Merged
@sandrobonazzola
Copy link
Contributor Author

Any hint on why _check_partitioning test failed? I thought I updated the relevant section within the test case.

@poncovka poncovka added the manual testing required This issue can't be merged without manual testing label Feb 24, 2022
@VladimirSlavik
Copy link
Contributor

/kickstart-test --testtype smoke

@jkonecny12 jkonecny12 added the blocked Don't merge this pull request! label Mar 1, 2022
@jkonecny12
Copy link
Member

Blocked - waiting on exception+.

@jstodola
Copy link
Contributor

jstodola commented Mar 3, 2022

Blocked - waiting on exception+.

exception+ granted.

VladimirSlavik
VladimirSlavik approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

jkonecny12
jkonecny12 approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jkonecny12
Copy link
Member

For some reason can't remove the blocked label :(.

@VladimirSlavik VladimirSlavik removed the blocked Don't merge this pull request! label Mar 4, 2022
@VladimirSlavik
Copy link
Contributor

I couldn't do it, too. Now it worked, though.

poncovka
poncovka reviewed Mar 8, 2022
View reviewed changes
Copy link
Contributor

@poncovka poncovka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request will be merged to RHEL 8.7. Please, add Resolves: rhbz#2060376 to the commit message. I will handle the pull request for RHEL 8.6.

data/product.d/ovirt.conf Show resolved Hide resolved
@poncovka poncovka mentioned this pull request Mar 8, 2022
Merged
@sandrobonazzola
ovirt: move /var/tmp and /var/crash to own partition
0e4a8b4 
Resolves: rhbz#2060376
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2057475
Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
@sandrobonazzola
Copy link
Contributor Author

Please, add Resolves: rhbz#2060376 to the commit message

Done

@rvykydal
Copy link
Contributor

rvykydal commented Mar 9, 2022

/kickstart-test --testtype smoke

@poncovka poncovka removed the manual testing required This issue can't be merged without manual testing label Mar 10, 2022
poncovka
poncovka approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@poncovka poncovka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@poncovka poncovka added the ready to merge The PR can be merged. It should have all BZ flags required for releasing set (usually release+). label Mar 10, 2022
@rvykydal rvykydal merged commit 8428d64 into rhinstaller:rhel-8 Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvykydal rvykydal rvykydal approved these changes

@jkonecny12 jkonecny12 jkonecny12 approved these changes

@poncovka poncovka poncovka approved these changes

@VladimirSlavik VladimirSlavik VladimirSlavik approved these changes

Assignees

@poncovka poncovka

Labels
ready to merge The PR can be merged. It should have all BZ flags required for releasing set (usually release+). rhel8-branch
Milestone
No milestone
6 participants
@sandrobonazzola @VladimirSlavik @jkonecny12 @jstodola @rvykydal @poncovka