Prefer GPT instead of legacy MBR #4232
Conversation
poncovka
added
manual testing required
|
This looks good, but is there a reason we want Anaconda's core default to remain MBR? |
poncovka
changed the title
inst.disklabel boot optioninst.disklabel version)
No idea. @jkonecny12? @jstodola? |
|
I'm not aware of any reason why MBR should remain the default. IMO, it makes sense to make GPT the default for all future products, not just Fedora. The disk label would be unified across all systems with all disk sizes. |
poncovka
force-pushed
the
master-disk_label
branch
from
109807d
to
4a76e43
Compare
poncovka
changed the title
inst.disklabel version)
Use the `inst.disklabel` boot option to specify a preferred disk label type. Specify `gpt` to prefer creation of GPT disk labels. Specify `mbr` to prefer creation of MBR disk labels if supported. The `inst.gpt` boot option is deprecated and will be removed in future releases.
Fedora Linux systems installed on legacy x86 BIOS systems should get GPT partitioning by default instead of legacy MBR partitioning. This should be a new default for all products. See: https://fedoraproject.org/wiki/Changes/GPTforBIOSbyDefault
Implement new unit tests for the `_set_default_label_type` function.
Document all changes related to the default disk label type.
poncovka
force-pushed
the
master-disk_label
branch
from
e9bab0e
to
7701c71
Compare
poncovka
changed the title
poncovka
removed
the
manual testing required
|
Updated and tested. |
|
/kickstart-test --testtype smoke |
|
This PR arguably does rather a lot more than was actually requested, and broke at least one thing. See https://bugzilla.redhat.com/show_bug.cgi?id=2092091#c6 and https://bugzilla.redhat.com/show_bug.cgi?id=2209760 . Why was this implemented this way, instead of by just tweaking the existing logic in blivet? |
@AdamWill I don't remember all details, but this was the original proposal #4104, so we just went from there. It looks like @vojtechtrefny actually suggested to change the order of disk labels in Blivet at #4104 (comment), but we never followed up on that. I don't know why. Anyway, it should be pretty straightforward to fix this. If Blivet changes the order of disk labels, Anaconda can re-enable Blivet's defaults in the Anaconda configuration file via the |
|
Sure, that's what I was going to propose too, if there wasn't any non-obvious reason not to do it. Here's the blivet PR: storaged-project/blivet#1132 |
rhinstaller#4232 made anaconda prefer GPT disk labels by default. This was intended to implement the Change called "Install Using GPT on x86_64 BIOS by Default": https://fedoraproject.org/wiki/Changes/GPTforBIOSbyDefault https://bugzilla.redhat.com/show_bug.cgi?id=2092091 However, it actually does more than that Change requested. It prefers GPT in other cases - it's quite hard to parse out every possible case this changes, but for example, it also prefers GPT on ppc64le installs, which previously preferred MBR. It's also just an odd approach, when blivet already goes to some lengths specifically to provide a list of supported label types in a preferred order. It makes much more sense for anaconda to keep respecting the order of the list blivet provides, and adjust blivet to list GPT first on x86_64. The config setting and `inst.disklabel` boot option can still be used to force a preference; this just makes the default config value unset rather than 'gpt'. This goes with this blivet PR that implements preferring GPT on x86_64 (even on BIOS): storaged-project/blivet#1132 Signed-off-by: Adam Williamson <awilliam@redhat.com>
rhinstaller#4232 made anaconda prefer GPT disk labels by default. This was intended to implement the Change called "Install Using GPT on x86_64 BIOS by Default": https://fedoraproject.org/wiki/Changes/GPTforBIOSbyDefault https://bugzilla.redhat.com/show_bug.cgi?id=2092091 However, it actually does more than that Change requested. It prefers GPT in other cases - it's quite hard to parse out every possible case this changes, but for example, it also prefers GPT on ppc64le installs, which previously preferred MBR. It's also just an odd approach, when blivet already goes to some lengths specifically to provide a list of supported label types in a preferred order. It makes much more sense for anaconda to keep respecting the order of the list blivet provides, and adjust blivet to list GPT first on x86_64. The config setting and `inst.disklabel` boot option can still be used to force a preference; this just makes the default config value unset rather than 'gpt'. This goes with this blivet PR that implements preferring GPT on x86_64 (even on BIOS): storaged-project/blivet#1132 Signed-off-by: Adam Williamson <awilliam@redhat.com>
rhinstaller#4232 made anaconda prefer GPT disk labels by default. This was intended to implement the Change called "Install Using GPT on x86_64 BIOS by Default": https://fedoraproject.org/wiki/Changes/GPTforBIOSbyDefault https://bugzilla.redhat.com/show_bug.cgi?id=2092091 However, it actually does more than that Change requested. It prefers GPT in other cases - it's quite hard to parse out every possible case this changes, but for example, it also prefers GPT on ppc64le installs, which previously preferred MBR. It's also just an odd approach, when blivet already goes to some lengths specifically to provide a list of supported label types in a preferred order. It makes much more sense for anaconda to keep respecting the order of the list blivet provides, and adjust blivet to list GPT first on x86_64. The config setting and `inst.disklabel` boot option can still be used to force a preference; this just makes the default config value unset rather than 'gpt'. This goes with this blivet PR that implements preferring GPT on x86_64 (even on BIOS): storaged-project/blivet#1132 Signed-off-by: Adam Williamson <awilliam@redhat.com>
Use the
inst.disklabelboot option to specify a preferred disk label type. Specifygptto prefer creation of GPT disk labels. Specifymbrto prefer creation of MBRdisk labels if supported. The
inst.gptboot option is deprecated and will be removedin future releases.
The default value of the preferred disk label type is specified by the
disk_label_typeoption in the Anaconda configuration files. The
gptconfiguration option is no longersupported.
Fedora Linux systems installed on legacy x86 BIOS systems should get GPT partitioning by
default instead of legacy MBR partitioning. This should be a new default for all products.
See: https://fedoraproject.org/wiki/Changes/GPTforBIOSbyDefault