Fix driverdisk-disk test #35
Conversation
| @@ -26,7 +26,7 @@ RESULTFILE=$SYSROOT/root/RESULT | |||
| fail() { echo "*** $*" >> $RESULTFILE; } | |||
|
|
|||
| # check the installer environment | |||
| [ -f /lib/modules/`uname -r`/updates/fake-dd.ko ] || fail "kmod not loaded" | |||
| [ -f /usr/lib/modules/3.0.0/extra/fake-dd.ko ] || fail "kmod not loaded" | |||
There was a problem hiding this comment.
Is the folder really fixed or is the above path just now?
There was a problem hiding this comment.
This folder is created by the RPM with driver disk. The RPM is created by the script in lib/mkdud.py and there is 3.0.0 as kernel version if version is not set. Because the tests are run on boot.iso, we don't know which kernel version is there in time of the script execution.
This can be improved by grabbing logs from Lorax when building this iso or by running the boot.iso in some pre-testing phase but I don't think it's so much valuable for us now. But it could be a nice improvement for the tests in future.
|
Looks good to me! In fact, I'd suggest that you add your above comments about why the version is |
Driver disk .ko file was generated to folder /usr/lib/modules/3.0.0/extra/ but test pointed to location /lib/modules/`uname -r`/updates/. Fix location in test. Explanation: Module version folder is created by the RPM with driver disk. The RPM is created by the script in lib/mkdud.py. The kernel version is 3.0.0 if version parameter is not explicitly set. Because the tests are run on a boot.iso, we don't know which kernel version is there in time of the script execution. TODO: This can be improved by grabbing logs from Lorax when building this iso or by running the boot.iso in some pre-testing phase.
jkonecny12
force-pushed
the
master-fix-driverdisk-disk
branch
from
e17f40b
to
f301d9a
Compare
|
Updated with added explanation. Thank you will for pointing this out. |
Driver disk .ko file was generated to folder
/usr/lib/modules/3.0.0/extra/but test pointed to location/lib/modules/uname -r/updates/.Fix location in test.