LOG-5737: OpenShift Logging Conventions #6
Conversation
|
Sorry for accidentally pushing to the wrong fork. 😞 |
cluster-logging.md
Outdated
|
|
||
| ### Log Entry Structure | ||
|
|
||
| All log streams include the following [logData](https://opentelemetry.io/docs/specs/otel/logs/data-model/#log-and-event-record-definition) fields |
There was a problem hiding this comment.
This makes more sense to call logRecords since its the key rather than logData.
Is there any value in an example snippet of the yaml here?
There was a problem hiding this comment.
A snippet from here, may be helpful:
https://github.com/open-telemetry/opentelemetry-proto/blob/main/examples/logs.json#L28
There was a problem hiding this comment.
I chose "logData", which should have been "log data" because that is the header text for the spec, though in general I find this page only useful when paired with the proto buff definition. It is not obvious, IMO, how to build the payload from this document.
cluster-logging.md
Outdated
| * `scope` for a scope attribute | ||
| * `log` for a log attribute | ||
|
|
||
|
|
cluster-logging.md
Outdated
| | `body` | all | | | ||
| | `observedTimeUnixNano` | all | | | ||
| | `timeUnixNano` | all | | | ||
| | `severityNumber` | container, journal | | |
There was a problem hiding this comment.
Do we already send a "log level number"? If not, we might skip on this and continue just using the text representation. We can still add the field when someone needs it...
There was a problem hiding this comment.
We do not send the number in Viaq, all instance are translated from number to text and text has a pretty specific definition here which seems excessive.
There was a problem hiding this comment.
Settled on removing severityNumber
7 participants
This PR:
Ref: https://issues.redhat.com/browse/LOG-5737
cc @
cahartma @pavolloffay @xperimental @periklis