Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart Renders infinitely #63

Closed
brittsikora opened this issue Apr 17, 2017 · 5 comments
Closed

Chart Renders infinitely #63

brittsikora opened this issue Apr 17, 2017 · 5 comments
Assignees
Milestone

Comments

@brittsikora
Copy link

brittsikora commented Apr 17, 2017

To reproduce:

Pull up CAT in FireFox: https://jwildfire.github.io/CAT/
Confirm the renderer is web-codebook renderer
Input version as: ded094e
Confirm data file is safetyData-queries/ADAE.csv
Click "Render Chart"
Click the grey arrow next to the AGE to expand the chart
Watch the chart expand for all eternity

1912_8851

@jwildfire jwildfire added this to the v1.0.0 milestone Apr 17, 2017
@jwildfire
Copy link
Contributor

This happens because the getbbox implementation is a bit inconsistent across browsers. Bombs in firefox and IE. Not quite sure why this causes the chart to renderer endlessly though ...

@jwildfire
Copy link
Contributor

The text needs to be visible when getbbox is called in FF and IE. Removing this bit of css fixes the bug:

.web-codebook .summaryTable .variable-row .row-chart .tooltip {
   display: none;
}

Of course, now all of the tooltips are visible at the same time. I'm thinking we'll just hide them immediately after calling getbbox

@jwildfire
Copy link
Contributor

Left the css the same, but set the tooltip class after calling getBBox(), which seems to do the trick in FF.

jwildfire added a commit that referenced this issue Apr 18, 2017
@jwildfire jwildfire mentioned this issue Apr 18, 2017
@jwildfire jwildfire self-assigned this Apr 18, 2017
@jwildfire
Copy link
Contributor

Test Notes: Just confirm that everything renders as expected in dev-v1.0.0

@brittsikora
Copy link
Author

Expected Result: Opted to "Show All Charts" and each chart rendered once.

Outcome: Pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants