Skip to content
This repository

Fix for System.open_url #115

Merged
merged 1 commit into from about 1 month ago

3 participants

nhinze Keith Gable dmitrys
nhinze

The following lines of code need to be added to support iPad 2. Without these lines, iPad 2 crashes on iOS 6 when trying to open the list of available apps to open the file with. This is to support opening files in other apps if file preview cannot read it.

nhinze Fix for System.open_url
The following lines of code need to be added to support iPad 2. Without these lines, iPad 2 crashes on iOS 6 when trying to open the list of available apps to open the file with. This is to support opening files in other apps if file preview cannot read it.
f335e88
Keith Gable

This patch still applies to Rho 4.

dmitrys dmitrys merged commit 565d34f into from
dmitrys dmitrys closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Dec 08, 2012
nhinze Fix for System.open_url
The following lines of code need to be added to support iPad 2. Without these lines, iPad 2 crashes on iOS 6 when trying to open the list of available apps to open the file with. This is to support opening files in other apps if file preview cannot read it.
f335e88
This page is out of date. Refresh to see the latest.
2  platform/iphone/Classes/AppManager/AppManager.m
@@ -441,6 +441,7 @@ - (void)openDocInteractCommand:(NSString*)url {
441 441
         BOOL result = [docController presentPreviewAnimated:YES];
442 442
         
443 443
         if (!result) {
  444
+            [docController retain];
444 445
             CGPoint centerPoint = [Rhodes sharedInstance].window.center;
445 446
             CGRect centerRec = CGRectMake(centerPoint.x, centerPoint.y, 0, 0);
446 447
             BOOL isValid = [docController presentOpenInMenuFromRect:centerRec inView:[Rhodes sharedInstance].window animated:YES];
@@ -450,6 +451,7 @@ - (void)openDocInteractCommand:(NSString*)url {
450 451
 
451 452
 - (void)documentInteractionControllerDidEndPreview:(UIDocumentInteractionController *)docController
452 453
 {
  454
+	[docController autorelease];
453 455
     //[docController release];
454 456
     //docController = nil;
455 457
 }
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.