Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[3.5] Escape table names when doing SQL queries #129

Closed
wants to merge 13 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

ziggythehamster commented Jan 28, 2013

Rho and Rhom don't escape table names when using them in SQL queries. This prevents you from having a model called "Group" for example. This patch corrects this error and escapes the table names in places that I found that they needed to be escaped in.

This seems to only really affect fixed schema applications, since the property bag code uses some fixed table names that aren't reserved SQL operators/keywords.

Contributor

genywind commented Apr 15, 2013

Hello, can you modify pull request to merge it into master branch, not 3-5-stable ?

Contributor

ziggythehamster commented Apr 22, 2013

Yes, I will modify this to work with master and send in a separate pull request for that.

Contributor

ziggythehamster commented Apr 22, 2013

@genywind - see pull request #142 for this applied to master.

Contributor

genywind commented Jul 8, 2013

merged to master

@genywind genywind closed this Jul 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment