This repository has been archived by the owner on Jul 11, 2022. It is now read-only.
Bug 1312405 - EAP7 - unable to create xa datasource - At least one xa-datasource-property is required #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-datasource-property is required EAP7, unlike EAP6, wants xa-datasource-properties to be part of the creation operation
| import static org.rhq.modules.plugins.wildfly10.DatasourceComponent.getConnectionPropertiesAsMap; | ||
| import static org.rhq.modules.plugins.wildfly10.DatasourceComponent.isXADatasourceResource; | ||
| import static org.rhq.core.domain.resource.CreateResourceStatus.*; | ||
| import static org.rhq.modules.plugins.wildfly10.DatasourceComponent.*; |
There was a problem hiding this comment.
You've forgot Eclipse settings, no * imports.
There was a problem hiding this comment.
Le 11/03/2016 21:59, Michael Burman a écrit :
You've forgot Eclipse settings, no * imports.
Sorry I could not find the setting in IDEA's Eclipse Formatter plugin.
Do you remember where I can configure this?
There was a problem hiding this comment.
Code style -> Java -> "Class count to use *" etc. set a high value to those.
|
@burmanm IDE setup fixed and PR updated |
|
@burmanm Thanks for the tips! |
burmanm
added a commit
that referenced
this pull request
Mar 14, 2016
Bug 1312405 - EAP7 - unable to create xa datasource - At least one xa-datasource-property is required
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 1312405 - EAP7 - unable to create xa datasource - At least one xa-datasource-property is required
EAP7, unlike EAP6, wants xa-datasource-properties to be part of the creation operation.
Same applies to regular datasource.