This repository has been archived by the owner on Jul 11, 2022. It is now read-only.
[BZ 1069648] Persist JAVA_OPTS from connection settings for Standalone se... #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What will happen if standalone.conf already has JAVA_OPTS set a few lines down? The rhq-props are set at the top and the other occurrence will overwrite that setting? |
|
Based on Monday's review I moved the section to the bottom of the file and will just override everything else set before. So now, the users could update (although not recommended) the conf file and not directly affect the RHQ updates. |
| @@ -28,10 +41,17 @@ | |||
| */ | |||
| public class StandaloneASDiscovery extends BaseProcessDiscovery { | |||
|
|
|||
| private static final Log log = LogFactory.getLog(BaseProcessDiscovery.class); | |||
There was a problem hiding this comment.
getLog(StandaloneASDiscovery.class) ?
|
Other than the comments I just added inline, the change looks good to me. |
added 9 commits
June 6, 2014 12:09
…d is additive to existing settings. This is a safer approach.
|
Looks good, merging... |
jshaughn
added a commit
that referenced
this pull request
Jun 6, 2014
[BZ 1069648] Persist JAVA_OPTS from connection settings for Standalone se...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...rvers.