Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBoss 4.2.3 issue because of JNDI lookup #123

Closed
rhuss opened this issue Dec 4, 2013 · 4 comments
Closed

JBoss 4.2.3 issue because of JNDI lookup #123

rhuss opened this issue Dec 4, 2013 · 4 comments
Milestone

Comments

@rhuss
Copy link
Owner

@rhuss rhuss commented Dec 4, 2013

See the forum for details.

A JNDI lookup during the server detection phase (done in the Weblogic Detector when collecting MBean Servers) borks the JNDI subsystem in JBoss 4.2.3 so that it is not usable anymore.

The solution would be to add a guard in addMBeanServer which checks via a class lookup whether it is really running in a Weblogic environment and only then doe the JNDI lookup.

@peter-svensson
Copy link

@peter-svensson peter-svensson commented Dec 5, 2013

I've not been on a WLS for some time but I know that we did a server detection for JBoss/Tomcat/WLS (versions 9,10,11) back then by trying to just load a application-server specific class
Something like:

someClassLoader.loadClass("weblogic/Server")
@rhuss
Copy link
Owner Author

@rhuss rhuss commented Dec 5, 2013

Ok, but I think this worked only for certain older versions of Weblogic. I will have a deeper lookup next week, thanks for the hint.

@rhuss rhuss modified the milestone: 1.2.1 Mar 24, 2014
rhuss added a commit that referenced this issue Apr 10, 2014
@rhuss
Copy link
Owner Author

@rhuss rhuss commented Apr 10, 2014

Sorry, took some time. I decided to check in the Weblogic detector whether we are running in JBoss and the avoid an JNDI lookup. This couples somewhat the Weblogic detector to JBoss but this is the fastest solution. And this extra check shouldn't harm anyway (its called only once).

@pliljenberg , could you please check, whether this works for you ? I've added this to 1.2.1 which will be released in about a week, so no hurry. If it doesn't work, we can reopen this issue and fix it for the next version.

@rhuss rhuss closed this Apr 10, 2014
@peter-svensson
Copy link

@peter-svensson peter-svensson commented Apr 14, 2014

@rhuss - I'm not using joloko for our Jboss anymore so I can't verify the fix but the code looks ok :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants