New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade json-simple to 1.1.1 #137

Closed
davsclaus opened this Issue May 5, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@rhuss

This comment has been minimized.

Owner

rhuss commented May 6, 2014

My feelings with respect to an upgrade of json-simple are mixed. The only thing 1.1.1 adds is a proper OSGi Manifest entry and a maven build. Unfortunately the pom.xml is broken and adds a plain dependency to junit (with default scoped). Also, debug information is switched on now, increasing the size of json-simple of about 50% (well, that's probably the smallest issue).

That was the reason, why I decided sometimes ago to avoid 1.1.1 and always embed json-simple where possible: It integrated in the jvm and OSGi agent jar and of course in the WAR of the web agent.

But more important, a version update won't fix AMQ-5091 I just tried the scenario you described with an json-simple 1.1.1 enabled JVM agent and get the same symptoms: When accessing the ActiveMQ included agent via port 8161 after an JVM agent has been attached, the IllegalAccessError is thrown. Another indicator that it has nothing todo with a version mismatch is, that the method signature and visibility given in the error message is the same in 1.1 and 1.1.1 (and in fact, there were no code changes at all between 1.1 and 1.1.1). IMO it is a classloader issue, but I'm still investigating, for which probably no easy fix it possible (except for avoiding two different kind of agents).

Unfortunately it seems that the project is quite dead (and if something happen, then very slowly. I tend to update to 1.1.1 (since I'm not so picky anymore about the size increase ;-), but again, that won't fix your issue.

@davsclaus

This comment has been minimized.

davsclaus commented May 6, 2014

Okay thanks for the detailed report.

@davsclaus davsclaus closed this May 6, 2014

@rhuss rhuss added this to the 1.2.2 milestone May 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment