New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JVM Agent and SSL client authentication does not work #166

Closed
nevenr opened this Issue Oct 21, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@nevenr
Contributor

nevenr commented Oct 21, 2014

http://jolokia.963608.n3.nabble.com/JVM-Agent-and-SSL-client-authentication-td4024117.html
JVM Agent and SSL client authentication
Jul 19, 2013; 11:31am — by Erik Erik
Hello,

I have been testing Jolokia JVM agent with HTTPS and client authentication.
The HTTPS works fine, but I couldn't make SSL client authentication work.

I have used the following parameters :
protocol=https
keystore=keystore_server
keystorePassword=mypassword
useSslClientAuthentication=true

I don't know Java very well, but I tried to look into the code and I think there may be 2 problems :
1 - The HTTPS server uses the same keystore file as server key file and trust store file. Usually it key store and the trust store are separated. There is no parameter to specify the location of a separate truststore file.
2 - The useSslClientAuthentication does not seem to be read correctly. In the source file JolokiaServerConfig.java, the parameter value is read with Boolean.getBoolean(auth). Shouldn't it be Boolean.valueOf(auth) instead ? (because Boolean.getBoolean() reads the system property value).

Anyway I couldn't make SSL Client authentication work. Am I missing something ?

Thank you for your attention.

nevenr added a commit to nevenr/jolokia that referenced this issue Oct 21, 2014

Documentation update for:
- JVM Agent and SSL client authentication does not work rhuss#166
- Enabling additional configuration parameters for HTTPS rhuss#167
@nevenr

This comment has been minimized.

Contributor

nevenr commented Oct 21, 2014

Fixed.
Commits:
nevenr@f176c49
nevenr@3350aef

@nevenr nevenr closed this Oct 21, 2014

@nevenr nevenr reopened this Oct 29, 2014

@nevenr

This comment has been minimized.

Contributor

nevenr commented Oct 29, 2014

Please add milestone 1.3.0 and assign to me.
Thanks,
N.

@rhuss rhuss added this to the 1.3.0 milestone Nov 8, 2014

rhuss added a commit that referenced this issue Nov 8, 2014

Documentation update for:
- JVM Agent and SSL client authentication does not work #166
- Enabling additional configuration parameters for HTTPS #167
@rhuss

This comment has been minimized.

Owner

rhuss commented Nov 9, 2014

I added this to 1.2.3 Please let me know, whether it works for you. If not please reopen the issue.

@rhuss rhuss closed this Nov 9, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment