Use system properties on the HttpClient that's used in J4pClientBuilder

[christian-posta]

At the moment, i can't find a good way to tell the jolokia client to use an http/https proxy. Using the http_proxy env variables don't work; maybe we can enhance the J4pClientBuilder to call HttpClient.custom().useSystemProperties() as part of it's call so we can set system props to configure the http proxy

related: fabric8io/fabric8#2972

[rhuss]

Yes, thins also that its a good idea to allow environments variables for setting this proxy because this should not be part of any internal configuration files (but this should be possible, too).

Have to think a bit about it, but would also highly appreciate a pull request (quite busy these days ;-)

I think a J4pClientBuilder should have direct method for setting the proxy (like proxy(...)) and a sth like useProxyFromEnvironment() (which then is delegated to the HttpClient).

[christian-posta]

For sure. I'll get one together tonight. Thanks for the thoughts.

On Mon, Nov 3, 2014 at 2:15 PM, Roland Huß notifications@github.com wrote:

Yes, thins also that its a good idea to allow environments variables for
setting this proxy because this should not be part of any internal
configuration files (but this should be possible, too).

Have to think a bit about it, but would also highly appreciate a pull
request (quite busy these days ;-)

I think a J4pClientBuilder should have direct method for setting the proxy
(like proxy(...)) and a sth like useProxyFromEnvironment() (which then is
delegated to the HttpClient).

—
Reply to this email directly or view it on GitHub
#169 (comment).

Christian Posta
http://www.christianposta.com/blog
http://fabric8.io
twitter: @christianposta

[davsclaus]

+1

[rhuss]

Merged into master, thanks Neven !

[jcordes73]

@christian-posta Is it now working for you?

[rhuss]

What's the status of this one ? It should work now in the latest Jolokia release, going to close this for now.

Please feel free to reopen if there is still any issue with that.