New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use system properties on the HttpClient that's used in J4pClientBuilder #169

Closed
christian-posta opened this Issue Nov 3, 2014 · 6 comments

Comments

Projects
None yet
4 participants
@christian-posta

christian-posta commented Nov 3, 2014

At the moment, i can't find a good way to tell the jolokia client to use an http/https proxy. Using the http_proxy env variables don't work; maybe we can enhance the J4pClientBuilder to call HttpClient.custom().useSystemProperties() as part of it's call so we can set system props to configure the http proxy

related: fabric8io/fabric8#2972

@rhuss

This comment has been minimized.

Owner

rhuss commented Nov 3, 2014

Yes, thins also that its a good idea to allow environments variables for setting this proxy because this should not be part of any internal configuration files (but this should be possible, too).

Have to think a bit about it, but would also highly appreciate a pull request (quite busy these days ;-)

I think a J4pClientBuilder should have direct method for setting the proxy (like proxy(...)) and a sth like useProxyFromEnvironment() (which then is delegated to the HttpClient).

@christian-posta

This comment has been minimized.

christian-posta commented Nov 3, 2014

For sure. I'll get one together tonight. Thanks for the thoughts.

On Mon, Nov 3, 2014 at 2:15 PM, Roland Huß notifications@github.com wrote:

Yes, thins also that its a good idea to allow environments variables for
setting this proxy because this should not be part of any internal
configuration files (but this should be possible, too).

Have to think a bit about it, but would also highly appreciate a pull
request (quite busy these days ;-)

I think a J4pClientBuilder should have direct method for setting the proxy
(like proxy(...)) and a sth like useProxyFromEnvironment() (which then is
delegated to the HttpClient).


Reply to this email directly or view it on GitHub
#169 (comment).

Christian Posta
http://www.christianposta.com/blog
http://fabric8.io
twitter: @christianposta

@rhuss rhuss added this to the 1.3.1 milestone Nov 8, 2014

@davsclaus

This comment has been minimized.

davsclaus commented Nov 27, 2014

+1

nevenr added a commit to nevenr/jolokia that referenced this issue Dec 11, 2014

Issue rhuss#169 Use system properties on the HttpClient that's used i…
…n J4pClientBuilder

* J4pClientBuilder.proxy
* J4pClientBuilder.useProxyFromEnvironment

rhuss added a commit that referenced this issue Dec 23, 2014

@rhuss

This comment has been minimized.

Owner

rhuss commented Dec 23, 2014

Merged into master, thanks Neven !

@jcordes73

This comment has been minimized.

Contributor

jcordes73 commented Jan 26, 2015

@christian-posta Is it now working for you?

@rhuss

This comment has been minimized.

Owner

rhuss commented Jul 13, 2015

What's the status of this one ? It should work now in the latest Jolokia release, going to close this for now.

Please feel free to reopen if there is still any issue with that.

@rhuss rhuss closed this Jul 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment