New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom restrictor using JolokiaHttpHandler #224

Open
pwielgolaski opened this Issue Oct 28, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@pwielgolaski

pwielgolaski commented Oct 28, 2015

I wonder what are my options to use custom restrictor when I have already HttpServer setup (sun).
I would like to define my own restrictor, not using policy.

Could we?

  • make protected method Restrictor createRestrictor(Configuration pConfig)
  • give possibility to define class for restrictor in configuration
  • accept restrictor in constructor in similar way as AgentServlet does it
@rhuss

This comment has been minimized.

Owner

rhuss commented Nov 1, 2015

Yes, restrictor should be more extensible (Jolokia 2.0 already will provide the proper hooks)

Since I'm currently on vacations this might take two Wood until I can pick that up. Hope that's OK.

nevenr added a commit to nevenr/jolokia that referenced this issue Nov 2, 2015

@nevenr

This comment has been minimized.

Contributor

nevenr commented Nov 2, 2015

Hi guys,

restrictorClass parameter is added. AgentServlet and JolokiaHttpHandler are adopted.
if you think this change (nevenr@94a1ed5) is good enough I will create PR.

Regards,
N.

rhuss added a commit that referenced this issue Jan 18, 2016

@rhuss rhuss added this to the 1.3.3 milestone Jan 18, 2016

@rhuss rhuss modified the milestones: 1.3.3, 1.3.4 Apr 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment