New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jolokia Server does not shutdown properly #37

Closed
senthilnest opened this Issue Oct 29, 2011 · 1 comment

Comments

Projects
None yet
2 participants
@senthilnest
Contributor

senthilnest commented Oct 29, 2011

The problem is that the threads created by the Jolokia Server themselves as part of the Executor are not tagged as daemon threads. So when the cleanup threads tries to see if it shuts down, the threads that was created in the Executor will stop it from shutting down.

I made a change to use a threadfactory to make them all daemon threads to get around this. You can see it at https://github.com/senthilnest/jolokia. If it makes sense could you pull that?

@rhuss

This comment has been minimized.

Owner

rhuss commented Oct 29, 2011

This makes absolutely sense. I added the patch and pushed it upwards. It will be in 1.0.1 coming out rather soon.

Thanks a lot !

@rhuss rhuss closed this Oct 29, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment