Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to load multiple CA certs from store #403

Closed
dsimansk opened this issue May 23, 2019 · 6 comments
Closed

Add support to load multiple CA certs from store #403

dsimansk opened this issue May 23, 2019 · 6 comments

Comments

@dsimansk
Copy link
Contributor

@dsimansk dsimansk commented May 23, 2019

It'd be great to add a support for multiple CA certs.

public static void updateWithCaPem(KeyStore pTrustStore, File pCaCert)
throws IOException, CertificateException, KeyStoreException, NoSuchAlgorithmException {
InputStream is = new FileInputStream(pCaCert);
try {
CertificateFactory certFactory = CertificateFactory.getInstance("X509");
X509Certificate cert = (X509Certificate) certFactory.generateCertificate(is);
String alias = cert.getSubjectX500Principal().getName();
pTrustStore.setCertificateEntry(alias, cert);
} finally {
is.close();
}
}

In fact it's a bug affecting latest versions of OpenShift. The same issue was fixed in openshift-ping.
jboss-openshift/openshift-ping#43

Cc @rhuss

@rhuss
Copy link
Owner

@rhuss rhuss commented May 23, 2019

Valid point, thanks for spotting this ! Not sure whether you want to send in a PR, but if so, I could release the next version of jolokia over the weekend.

@dsimansk
Copy link
Contributor Author

@dsimansk dsimansk commented May 23, 2019

@rhuss I've created a PR, please take a look when it suits you. It's not so urgent as there's another issues on the OpenShift side. However, it might be good to have this one resolved just in case. :)

@rhuss
Copy link
Owner

@rhuss rhuss commented May 24, 2019

Thanks a lot ! I will have a look ASAP, also because I guess it will take a bit until it bubbles up to the images using Jolokia. So I agree, that Jolokia should be ready soon.

@rhuss rhuss closed this in #404 May 24, 2019
@paoloantinori
Copy link
Contributor

@paoloantinori paoloantinori commented Jun 17, 2019

Hi Roland!

Do you have plans for a release anytime soon? We'd like to use this functionality for OpenShift 4 related setups.

@rhuss
Copy link
Owner

@rhuss rhuss commented Jun 17, 2019

@paoloantinori I have no concrete plans but can do a release soonish. If there won't be a release until the end of the week, please ping me again.

@paoloantinori
Copy link
Contributor

@paoloantinori paoloantinori commented Jun 17, 2019

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants